From: Kalle Valo <kvalo@kernel.org>
To: Su Hui <suhui@nfschina.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH wireless-next] wlcore: debugfs: add an error code check in beacon_filtering_write
Date: Mon, 13 Nov 2023 14:07:43 +0200 [thread overview]
Message-ID: <878r71vots.fsf@kernel.org> (raw)
In-Reply-To: <065d6090-38fc-0cc0-db47-f9ba5b1c5d7d@nfschina.com> (Su Hui's message of "Mon, 13 Nov 2023 14:53:28 +0800")
Su Hui <suhui@nfschina.com> writes:
> On 2023/11/13 14:16, Kalle Valo wrote:
>
>> Su Hui <suhui@nfschina.com> writes:
>>
>>> wl1271_acx_beacon_filter_opt() return error code if failed, add a check
>>> for this is better and safer.
>>>
>>> Signed-off-by: Su Hui <suhui@nfschina.com>
>> How did you test this?
>
> Only compile test.
If you have only compile tested please document that clearly in the
commit message.
> Clang static checker complains about this code that value stored to
> 'ret' is never read.
This would be good to also have in the commit message.
> And most of the caller check the error code of
> wl1271_acx_beacon_filter_opt().
This might still break something so I would prefer to test this in a
real device before taking it.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-11-13 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 4:41 [PATCH wireless-next] wlcore: debugfs: add an error code check in beacon_filtering_write Su Hui
2023-11-13 6:16 ` Kalle Valo
2023-11-13 6:53 ` Su Hui
2023-11-13 12:07 ` Kalle Valo [this message]
2023-11-15 3:40 ` Su Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r71vots.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox