From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Robert Marko <robert.marko@sartura.hr>,
andrew@lunn.ch, sebastian.hesselbarth@gmail.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: luka.perkov@sartura.hr, Robert Marko <robert.marko@sartura.hr>
Subject: Re: [PATCH 1/2] arm64: dts: marvell: uDPU: rename the SFP GPIO properties
Date: Wed, 20 Sep 2023 11:57:23 +0200 [thread overview]
Message-ID: <878r91f9q4.fsf@BL-laptop> (raw)
In-Reply-To: <20230914094550.1519097-1-robert.marko@sartura.hr>
Robert Marko <robert.marko@sartura.hr> writes:
> Rename the GPIO related SFP properties to include the preffered -gpios
> suffix as defined in the SFP schema.
>
> This fixes the following warning:
> arch/arm64/boot/dts/marvell/armada-3720-eDPU.dtb: sfp-eth1: 'los-gpio', 'mod-def0-gpio', 'tx-disable-gpio', 'tx-fault-gpio' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/net/sff,sfp.yaml#
>
Applied on mvebu/dt64
Thanks,
Gregory
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
> index 3f79923376fb..3a9b6907185d 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
> @@ -61,10 +61,10 @@ led-alarm2 {
> sfp_eth1: sfp-eth1 {
> compatible = "sff,sfp";
> i2c-bus = <&i2c1>;
> - los-gpio = <&gpiosb 7 GPIO_ACTIVE_HIGH>;
> - mod-def0-gpio = <&gpiosb 8 GPIO_ACTIVE_LOW>;
> - tx-disable-gpio = <&gpiosb 9 GPIO_ACTIVE_HIGH>;
> - tx-fault-gpio = <&gpiosb 10 GPIO_ACTIVE_HIGH>;
> + los-gpios = <&gpiosb 7 GPIO_ACTIVE_HIGH>;
> + mod-def0-gpios = <&gpiosb 8 GPIO_ACTIVE_LOW>;
> + tx-disable-gpios = <&gpiosb 9 GPIO_ACTIVE_HIGH>;
> + tx-fault-gpios = <&gpiosb 10 GPIO_ACTIVE_HIGH>;
> maximum-power-milliwatt = <3000>;
> };
> };
> --
> 2.41.0
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
prev parent reply other threads:[~2023-09-20 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 9:45 [PATCH 1/2] arm64: dts: marvell: uDPU: rename the SFP GPIO properties Robert Marko
2023-09-14 9:45 ` [PATCH 2/2] arm64: dts: marvell: eDPU: add support for version with external switch Robert Marko
2023-09-14 12:51 ` Andrew Lunn
2023-09-14 12:52 ` Robert Marko
2023-09-14 15:05 ` Andrew Lunn
2023-09-20 9:57 ` Gregory CLEMENT
2023-09-14 12:48 ` [PATCH 1/2] arm64: dts: marvell: uDPU: rename the SFP GPIO properties Andrew Lunn
2023-09-20 9:57 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r91f9q4.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox