* [PATCH v2 1/5] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
2023-07-04 4:46 [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks Luke D. Jones
@ 2023-07-04 4:46 ` Luke D. Jones
2023-07-04 4:46 ` [PATCH v2 2/5] ALSA: hda/realtek: Add quirk for ASUS ROG GA402X Luke D. Jones
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Luke D. Jones @ 2023-07-04 4:46 UTC (permalink / raw)
To: tiwai
Cc: perex, sbinding, andy.chi, tcrawford, tangmeng, p.jungkamp,
kasper93, ruinairas1992, yangyuchi66, yangyingliang, linux-kernel,
alsa-devel, Luke D. Jones
Adds the required quirk to enable the Cirrus amp and correct pins
on the ASUS ROG GV601V series which uses an I2C connected Cirrus amp.
While this works if the related _DSD properties are made available, these
aren't included in the ACPI of these laptops (yet).
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index afe8253f9a4f..b41fdf22157c 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7068,6 +7068,8 @@ enum {
ALC285_FIXUP_SPEAKER2_TO_DAC1,
ALC285_FIXUP_ASUS_SPEAKER2_TO_DAC1,
ALC285_FIXUP_ASUS_HEADSET_MIC,
+ ALC285_FIXUP_ASUS_I2C_SPEAKER2_TO_DAC1,
+ ALC285_FIXUP_ASUS_I2C_HEADSET_MIC,
ALC280_FIXUP_HP_HEADSET_MIC,
ALC221_FIXUP_HP_FRONT_MIC,
ALC292_FIXUP_TPT460,
@@ -8058,6 +8060,22 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC285_FIXUP_ASUS_SPEAKER2_TO_DAC1
},
+ [ALC285_FIXUP_ASUS_I2C_SPEAKER2_TO_DAC1] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc285_fixup_speaker2_to_dac1,
+ .chained = true,
+ .chain_id = ALC287_FIXUP_CS35L41_I2C_2
+ },
+ [ALC285_FIXUP_ASUS_I2C_HEADSET_MIC] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x19, 0x03a11050 },
+ { 0x1b, 0x03a11c30 },
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC285_FIXUP_ASUS_I2C_SPEAKER2_TO_DAC1
+ },
[ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
.type = HDA_FIXUP_PINS,
.v.pins = (const struct hda_pintbl[]) {
@@ -9573,6 +9591,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1313, "Asus K42JZ", ALC269VB_FIXUP_ASUS_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC),
SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK),
+ SND_PCI_QUIRK(0x1043, 0x1433, "ASUS GX650P", ALC285_FIXUP_ASUS_I2C_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1473, "ASUS GU604V", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1483, "ASUS GU603V", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC),
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 2/5] ALSA: hda/realtek: Add quirk for ASUS ROG GA402X
2023-07-04 4:46 [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks Luke D. Jones
2023-07-04 4:46 ` [PATCH v2 1/5] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P Luke D. Jones
@ 2023-07-04 4:46 ` Luke D. Jones
2023-07-04 4:46 ` [PATCH v2 3/5] ALSA: hda/realtek: Amend G634 quirk to enable rear speakers Luke D. Jones
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Luke D. Jones @ 2023-07-04 4:46 UTC (permalink / raw)
To: tiwai
Cc: perex, sbinding, andy.chi, tcrawford, tangmeng, p.jungkamp,
kasper93, ruinairas1992, yangyuchi66, yangyingliang, linux-kernel,
alsa-devel, Luke D. Jones
Adds the required quirk to enable the Cirrus amp and correct pins
on the ASUS ROG GA402X series which uses an I2C connected Cirrus amp.
While this works if the related _DSD properties are made available, these
aren't included in the ACPI of these laptops (yet).
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b41fdf22157c..1fae8e8b1234 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9592,6 +9592,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC),
SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK),
SND_PCI_QUIRK(0x1043, 0x1433, "ASUS GX650P", ALC285_FIXUP_ASUS_I2C_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1043, 0x1463, "Asus GA402X", ALC285_FIXUP_ASUS_I2C_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1473, "ASUS GU604V", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1483, "ASUS GU603V", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC),
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 3/5] ALSA: hda/realtek: Amend G634 quirk to enable rear speakers
2023-07-04 4:46 [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks Luke D. Jones
2023-07-04 4:46 ` [PATCH v2 1/5] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P Luke D. Jones
2023-07-04 4:46 ` [PATCH v2 2/5] ALSA: hda/realtek: Add quirk for ASUS ROG GA402X Luke D. Jones
@ 2023-07-04 4:46 ` Luke D. Jones
2023-07-04 4:46 ` [PATCH v2 4/5] ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx Luke D. Jones
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Luke D. Jones @ 2023-07-04 4:46 UTC (permalink / raw)
To: tiwai
Cc: perex, sbinding, andy.chi, tcrawford, tangmeng, p.jungkamp,
kasper93, ruinairas1992, yangyuchi66, yangyingliang, linux-kernel,
alsa-devel, Luke D. Jones
Amends the last quirk for the G634 with 0x1caf subsys to enable the rear
speakers via pincfg.
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 1fae8e8b1234..50becdc86daa 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7068,6 +7068,7 @@ enum {
ALC285_FIXUP_SPEAKER2_TO_DAC1,
ALC285_FIXUP_ASUS_SPEAKER2_TO_DAC1,
ALC285_FIXUP_ASUS_HEADSET_MIC,
+ ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS,
ALC285_FIXUP_ASUS_I2C_SPEAKER2_TO_DAC1,
ALC285_FIXUP_ASUS_I2C_HEADSET_MIC,
ALC280_FIXUP_HP_HEADSET_MIC,
@@ -8060,6 +8061,15 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC285_FIXUP_ASUS_SPEAKER2_TO_DAC1
},
+ [ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x14, 0x90170120 },
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC285_FIXUP_ASUS_HEADSET_MIC
+ },
[ALC285_FIXUP_ASUS_I2C_SPEAKER2_TO_DAC1] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc285_fixup_speaker2_to_dac1,
@@ -9622,7 +9632,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1c23, "Asus X55U", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1c92, "ASUS ROG Strix G15", ALC285_FIXUP_ASUS_G533Z_PINS),
- SND_PCI_QUIRK(0x1043, 0x1caf, "ASUS G634JYR/JZR", ALC285_FIXUP_ASUS_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1043, 0x1caf, "ASUS G634JYR/JZR", ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS),
SND_PCI_QUIRK(0x1043, 0x1ccd, "ASUS X555UB", ALC256_FIXUP_ASUS_MIC),
SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420", ALC256_FIXUP_ASUS_HPE),
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 4/5] ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx
2023-07-04 4:46 [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks Luke D. Jones
` (2 preceding siblings ...)
2023-07-04 4:46 ` [PATCH v2 3/5] ALSA: hda/realtek: Amend G634 quirk to enable rear speakers Luke D. Jones
@ 2023-07-04 4:46 ` Luke D. Jones
2023-07-04 4:46 ` [PATCH v2 5/5] Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for Dell DT) Luke D. Jones
2023-07-04 6:44 ` [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks Takashi Iwai
5 siblings, 0 replies; 8+ messages in thread
From: Luke D. Jones @ 2023-07-04 4:46 UTC (permalink / raw)
To: tiwai
Cc: perex, sbinding, andy.chi, tcrawford, tangmeng, p.jungkamp,
kasper93, ruinairas1992, yangyuchi66, yangyingliang, linux-kernel,
alsa-devel, Luke D. Jones
Adds the required quirk to enable the Cirrus amp and correct pins
on the ASUS ROG G614J series which uses an SPI connected Cirrus amp.
While this works if the related _DSD properties are made available, these
aren't included in the ACPI of these laptops (yet).
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 50becdc86daa..ba3c113f0be1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9632,6 +9632,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1c23, "Asus X55U", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1c92, "ASUS ROG Strix G15", ALC285_FIXUP_ASUS_G533Z_PINS),
+ SND_PCI_QUIRK(0x1043, 0x1c9f, "ASUS G614JI", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1caf, "ASUS G634JYR/JZR", ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS),
SND_PCI_QUIRK(0x1043, 0x1ccd, "ASUS X555UB", ALC256_FIXUP_ASUS_MIC),
SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401),
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 5/5] Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for Dell DT)
2023-07-04 4:46 [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks Luke D. Jones
` (3 preceding siblings ...)
2023-07-04 4:46 ` [PATCH v2 4/5] ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx Luke D. Jones
@ 2023-07-04 4:46 ` Luke D. Jones
2023-07-04 6:44 ` [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks Takashi Iwai
5 siblings, 0 replies; 8+ messages in thread
From: Luke D. Jones @ 2023-07-04 4:46 UTC (permalink / raw)
To: tiwai
Cc: perex, sbinding, andy.chi, tcrawford, tangmeng, p.jungkamp,
kasper93, ruinairas1992, yangyuchi66, yangyingliang, linux-kernel,
alsa-devel, Luke D. Jones
Remove an erroneous whitespace.
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ba3c113f0be1..1547c40dc7e9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5883,7 +5883,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,
struct alc_spec *spec = codec->spec;
spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
alc255_set_default_jack_type(codec);
- }
+ }
else
alc_fixup_headset_mode(codec, fix, action);
}
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks
2023-07-04 4:46 [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks Luke D. Jones
` (4 preceding siblings ...)
2023-07-04 4:46 ` [PATCH v2 5/5] Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for Dell DT) Luke D. Jones
@ 2023-07-04 6:44 ` Takashi Iwai
2023-07-04 23:18 ` Luke Jones
5 siblings, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2023-07-04 6:44 UTC (permalink / raw)
To: Luke D. Jones
Cc: tiwai, perex, sbinding, andy.chi, tcrawford, tangmeng, p.jungkamp,
kasper93, ruinairas1992, yangyuchi66, yangyingliang, linux-kernel,
alsa-devel
On Tue, 04 Jul 2023 06:46:14 +0200,
Luke D. Jones wrote:
>
> - Adds quirks for various ASUS ROG laptops.
> - Fixes up a previous quirk
> - Fixes up a whitespace error
>
> This introduces a quirk chain that is similar to the ROG Ally quirk chain, but
> due to the verb configs being currently tested these new quirks do not use it
> and instead add a new chain. It is likely the Ally quirk will be removed in
> favour of this new chain in future.
>
> Luke D. Jones (5):
> ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
> ALSA: hda/realtek: Add quirk for ASUS ROG GA402X
> ALSA: hda/realtek: Amend G634 quirk to enable rear speakers
> ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx
> Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for Dell
> DT)
Now applied all patches. The subject line of the last patch was
modified to match with the standard. The Fixes tag was moved to the
right place, too.
thanks,
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks
2023-07-04 6:44 ` [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks Takashi Iwai
@ 2023-07-04 23:18 ` Luke Jones
0 siblings, 0 replies; 8+ messages in thread
From: Luke Jones @ 2023-07-04 23:18 UTC (permalink / raw)
To: Takashi Iwai
Cc: tiwai, perex, sbinding, andy.chi, tcrawford, tangmeng, p.jungkamp,
kasper93, ruinairas1992, yangyuchi66, yangyingliang, linux-kernel,
alsa-devel
On Tue, 2023-07-04 at 08:44 +0200, Takashi Iwai wrote:
> On Tue, 04 Jul 2023 06:46:14 +0200,
> Luke D. Jones wrote:
> >
> > - Adds quirks for various ASUS ROG laptops.
> > - Fixes up a previous quirk
> > - Fixes up a whitespace error
> >
> > This introduces a quirk chain that is similar to the ROG Ally quirk
> > chain, but
> > due to the verb configs being currently tested these new quirks do
> > not use it
> > and instead add a new chain. It is likely the Ally quirk will be
> > removed in
> > favour of this new chain in future.
> >
> > Luke D. Jones (5):
> > ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
> > ALSA: hda/realtek: Add quirk for ASUS ROG GA402X
> > ALSA: hda/realtek: Amend G634 quirk to enable rear speakers
> > ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx
> > Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for
> > Dell
> > DT)
>
> Now applied all patches. The subject line of the last patch was
> modified to match with the standard. The Fixes tag was moved to the
> right place, too.
Thanks mate. I looked at the patch guidelines for that but I must have
misunderstood it :)
^ permalink raw reply [flat|nested] 8+ messages in thread