* [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform
@ 2023-01-05 4:41 Jeremy Szu
2023-01-05 4:44 ` Jeremy Szu
2023-01-05 8:45 ` Takashi Iwai
0 siblings, 2 replies; 5+ messages in thread
From: Jeremy Szu @ 2023-01-05 4:41 UTC (permalink / raw)
To: tiwai
Cc: Jeremy Szu, Jaroslav Kysela, Stefan Binding, Tim Crawford,
Meng Tang, Lucas Tanure, Kai-Heng Feng, Philipp Jungkamp,
Kacper Michajłow, Yuchi Yang, moderated list:SOUND,
open list
There is a HP platform uses ALC236 codec which using GPIO2 to control
mute LED and GPIO1 to control micmute LED.
Thus, add a quirk to make them work.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index eda4914b8aeb..8362eb4642d8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9409,6 +9409,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8bf0, "HP", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform
2023-01-05 4:41 [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Jeremy Szu
@ 2023-01-05 4:44 ` Jeremy Szu
2023-01-05 8:45 ` Takashi Iwai
1 sibling, 0 replies; 5+ messages in thread
From: Jeremy Szu @ 2023-01-05 4:44 UTC (permalink / raw)
To: tiwai
Cc: Jaroslav Kysela, Stefan Binding, Tim Crawford, Meng Tang,
Lucas Tanure, Kai-Heng Feng, Philipp Jungkamp,
Kacper Michajłow, Yuchi Yang, moderated list:SOUND,
open list
Besides this, it has the problem described in
https://lore.kernel.org/all/20220719144753.252231-1-kai.heng.feng@canonical.com/
but the solution could seperate with this quirk.
On Thu, Jan 5, 2023 at 12:42 PM Jeremy Szu <jeremy.szu@canonical.com> wrote:
>
> There is a HP platform uses ALC236 codec which using GPIO2 to control
> mute LED and GPIO1 to control micmute LED.
> Thus, add a quirk to make them work.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index eda4914b8aeb..8362eb4642d8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9409,6 +9409,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8bf0, "HP", ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
> SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
> SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> --
> 2.38.1
>
--
Sincerely,
Jeremy Su
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform
2023-01-05 4:41 [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Jeremy Szu
2023-01-05 4:44 ` Jeremy Szu
@ 2023-01-05 8:45 ` Takashi Iwai
1 sibling, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2023-01-05 8:45 UTC (permalink / raw)
To: Jeremy Szu
Cc: tiwai, Jaroslav Kysela, Stefan Binding, Tim Crawford, Meng Tang,
Lucas Tanure, Kai-Heng Feng, Philipp Jungkamp,
Kacper Michajłow, Yuchi Yang, moderated list:SOUND,
open list
On Thu, 05 Jan 2023 05:41:53 +0100,
Jeremy Szu wrote:
>
> There is a HP platform uses ALC236 codec which using GPIO2 to control
> mute LED and GPIO1 to control micmute LED.
> Thus, add a quirk to make them work.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform.
@ 2023-02-07 8:30 Andy Chi
2023-02-07 9:15 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Andy Chi @ 2023-02-07 8:30 UTC (permalink / raw)
Cc: andy.chi, Jaroslav Kysela, Takashi Iwai, Tim Crawford,
Stefan Binding, Meng Tang, Philipp Jungkamp,
Kacper Michajłow, Gabriele Mazzotta, Yuchi Yang, alsa-devel,
linux-kernel
There is a HP platform needs ALC236_FIXUP_HP_GPIO_LED quirk to
make mic-mute/audio-mute working.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4055a8f5880a..d1258dd803e8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9433,6 +9433,11 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8b7a, "HP", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b7d, "HP", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b8a, "HP", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b8b, "HP", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b8d, "HP", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b92, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8bf0, "HP", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform.
2023-02-07 8:30 Andy Chi
@ 2023-02-07 9:15 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2023-02-07 9:15 UTC (permalink / raw)
To: Andy Chi
Cc: Jaroslav Kysela, Takashi Iwai, Tim Crawford, Stefan Binding,
Meng Tang, Philipp Jungkamp, Kacper Michajłow,
Gabriele Mazzotta, Yuchi Yang, alsa-devel, linux-kernel
On Tue, 07 Feb 2023 09:30:09 +0100,
Andy Chi wrote:
>
> There is a HP platform needs ALC236_FIXUP_HP_GPIO_LED quirk to
> make mic-mute/audio-mute working.
>
> Signed-off-by: Andy Chi <andy.chi@canonical.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-07 9:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-05 4:41 [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Jeremy Szu
2023-01-05 4:44 ` Jeremy Szu
2023-01-05 8:45 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2023-02-07 8:30 Andy Chi
2023-02-07 9:15 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox