From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE16C433F5 for ; Wed, 23 Mar 2022 09:05:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243024AbiCWJGy (ORCPT ); Wed, 23 Mar 2022 05:06:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231246AbiCWJGx (ORCPT ); Wed, 23 Mar 2022 05:06:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5155374851 for ; Wed, 23 Mar 2022 02:05:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0468BB81E37 for ; Wed, 23 Mar 2022 09:05:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2579C340E8; Wed, 23 Mar 2022 09:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648026320; bh=ONIEXrMOX1ZLi0HKLJ1K0KQE/mWfAqH+3yaUYCp4nx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=n4Tr9zqHVg02aB4oZXbSz0wxvgfOWSxoS7lJTqYANciwt75B9Q/bVJBuTBy0YopD/ U9Z8oRS6eQnRy0jLA6rPnZy/48IbQsgY1MK0TUkUPqc2P6pfAA8jIvpgVzNRXKaSLU E3PtXQGkn5AxYE8Bk6bbi+4UN3RDKxOrVbt3J8qbxDgNBycl1RMdSLderdzOuAm9U1 kW7LUoV5Uiq9FftCO3oOnujHtb3HJa3ajEwHmcLBtD8oNca15yfO7g0n9sFPjM6tF3 HeJ6NG6cMPJV+2d33FXG0y+TKeliBwvWUF6qDetHtCPdK0f4cK5TLw1LB1pIRAXmiS gdo/47et/7C0g== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nWwth-00GSLU-UV; Wed, 23 Mar 2022 09:05:18 +0000 Date: Wed, 23 Mar 2022 09:03:17 +0000 Message-ID: <878rt1xcq2.wl-maz@kernel.org> From: Marc Zyngier To: Jason Wang Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, Stefano Garzarella , Keir Fraser Subject: Re: [PATCH 2/2] Revert "virtio_pci: harden MSI-X interrupts" In-Reply-To: <20220323031524.6555-2-jasowang@redhat.com> References: <20220323031524.6555-1-jasowang@redhat.com> <20220323031524.6555-2-jasowang@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jasowang@redhat.com, mst@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, sgarzare@redhat.com, keirf@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Mar 2022 03:15:24 +0000, Jason Wang wrote: > > This reverts commit 9e35276a5344f74d4a3600fc4100b3dd251d5c56. Issue > were reported for the drivers that are using affinity managed IRQ > where manually toggling IRQ status is not expected. And we forget to > enable the interrupts in the restore path as well. > > In the future, we will rework on the interrupt hardening. > > Fixes: 9e35276a5344 ("virtio_pci: harden MSI-X interrupts") > Reported-by: Marc Zyngier > Reported-by: Stefano Garzarella > Signed-off-by: Jason Wang For this patch and the INTx one: Acked-by: Marc Zyngier Please keep me in the loop when you decide to rework this. Thanks, M. -- Without deviation from the norm, progress is not possible.