From: Thomas Gleixner <tglx@linutronix.de>
To: Sami Tolvanen <samitolvanen@google.com>, x86@kernel.org
Cc: Kees Cook <keescook@chromium.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH 04/15] static_call: Use global functions for the self-test
Date: Sat, 17 Apr 2021 02:16:54 +0200 [thread overview]
Message-ID: <878s5hu5mx.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <87v98lud0z.ffs@nanos.tec.linutronix.de>
On Fri, Apr 16 2021 at 23:37, Thomas Gleixner wrote:
> On Fri, Apr 16 2021 at 13:38, Sami Tolvanen wrote:
>> #ifdef CONFIG_STATIC_CALL_SELFTEST
>>
>> -static int func_a(int x)
>> +int func_a(int x)
>> {
>> return x+1;
>> }
>>
>> -static int func_b(int x)
>> +int func_b(int x)
>> {
>> return x+2;
>> }
>
> Did you even compile that?
>
> Global functions without a prototype are generating warnings, but we can
> ignore them just because of sekurity, right?
>
> Aside of that polluting the global namespace with func_a/b just to work
> around a tool shortcoming is beyond hillarious.
>
> Fix the tool not the perfectly correct code.
That said, I wouldn't mind a __dont_dare_to_rename annotation to help
the compiler, but anything else is just wrong.
Thanks,
tglx
next prev parent reply other threads:[~2021-04-17 0:16 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 20:38 [PATCH 00/15] x86: Add support for Clang CFI Sami Tolvanen
2021-04-16 20:38 ` [PATCH 01/15] objtool: Find a destination for jumps beyond the section end Sami Tolvanen
2021-04-20 18:14 ` Josh Poimboeuf
2021-04-20 20:25 ` Sami Tolvanen
2021-04-20 22:55 ` Josh Poimboeuf
2021-04-20 22:58 ` Nick Desaulniers
2021-04-16 20:38 ` [PATCH 02/15] objtool: Add CONFIG_CFI_CLANG support Sami Tolvanen
2021-04-20 19:47 ` Josh Poimboeuf
2021-04-20 20:45 ` Sami Tolvanen
2021-04-16 20:38 ` [PATCH 03/15] objtool: Add ASM_STACK_FRAME_NON_STANDARD Sami Tolvanen
2021-04-16 20:38 ` [PATCH 04/15] static_call: Use global functions for the self-test Sami Tolvanen
2021-04-16 21:37 ` Thomas Gleixner
2021-04-17 0:16 ` Thomas Gleixner [this message]
2021-04-16 20:38 ` [PATCH 05/15] x86: Implement function_nocfi Sami Tolvanen
2021-04-16 21:18 ` Borislav Petkov
2021-04-16 21:49 ` Sami Tolvanen
2021-04-16 22:02 ` Borislav Petkov
2021-04-16 22:06 ` Andy Lutomirski
2021-04-16 22:14 ` Borislav Petkov
2021-04-16 22:20 ` Andy Lutomirski
2021-04-16 22:37 ` Kees Cook
2021-04-16 23:02 ` Thomas Gleixner
2021-04-17 10:16 ` Thomas Gleixner
2021-04-19 15:13 ` Sami Tolvanen
2021-04-16 22:28 ` Kees Cook
2021-04-16 22:52 ` Andy Lutomirski
2021-04-16 22:58 ` Kees Cook
2021-04-16 23:40 ` Kees Cook
2021-04-17 23:19 ` Andy Lutomirski
2021-04-17 23:53 ` Thomas Gleixner
2021-04-18 0:11 ` Andy Lutomirski
2021-04-18 16:17 ` Thomas Gleixner
2021-04-18 22:57 ` Andy Lutomirski
2021-04-19 15:20 ` Sami Tolvanen
2021-04-19 15:26 ` David Laight
2021-04-19 17:46 ` Andy Lutomirski
2021-04-17 14:20 ` David Laight
2021-04-17 15:48 ` Andy Lutomirski
2021-04-19 8:40 ` Rasmus Villemoes
2021-04-19 16:45 ` Joao Moreira
2021-04-19 21:52 ` David Laight
2021-04-16 22:16 ` Kees Cook
2021-04-16 22:13 ` Thomas Gleixner
2021-04-16 20:38 ` [PATCH 06/15] x86: Avoid CFI jump tables in IDT and entry points Sami Tolvanen
2021-04-16 22:26 ` Thomas Gleixner
2021-04-16 23:56 ` Kees Cook
2021-04-17 0:02 ` Thomas Gleixner
2021-04-16 20:38 ` [PATCH 07/15] x86/ftrace: Use function_nocfi in MCOUNT_ADDR Sami Tolvanen
2021-04-16 20:38 ` [PATCH 08/15] x86/extable: Do not mark exception callback as CFI Sami Tolvanen
2021-04-16 20:38 ` [PATCH 09/15] x86/alternatives: Use C int3 selftest but disable KASAN Sami Tolvanen
2021-04-17 11:37 ` Peter Zijlstra
2021-04-19 15:26 ` Sami Tolvanen
2021-04-20 7:19 ` Peter Zijlstra
2021-04-16 20:38 ` [PATCH 10/15] x86/purgatory: Disable CFI Sami Tolvanen
2021-04-16 20:38 ` [PATCH 11/15] x86, relocs: Ignore __typeid__ relocations Sami Tolvanen
2021-04-16 20:38 ` [PATCH 12/15] x86, module: " Sami Tolvanen
2021-04-16 20:38 ` [PATCH 13/15] x86, cpu: Use LTO for cpu.c with CFI Sami Tolvanen
2021-04-16 20:38 ` [PATCH 14/15] x86, kprobes: Fix optprobe_template_func type mismatch Sami Tolvanen
2021-04-16 20:38 ` [PATCH 15/15] x86, build: Allow CONFIG_CFI_CLANG to be selected Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s5hu5mx.ffs@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=clang-built-linux@googlegroups.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
--cc=sedat.dilek@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox