From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 771BDC388F9 for ; Mon, 23 Nov 2020 22:01:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0AA9206CA for ; Mon, 23 Nov 2020 22:01:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="G2VzHdD4"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="jbjqZF8K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730188AbgKWWBN (ORCPT ); Mon, 23 Nov 2020 17:01:13 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:38662 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728161AbgKWWBM (ORCPT ); Mon, 23 Nov 2020 17:01:12 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1606168870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nOgyExsMmcgulCtYSfwEoyMOFUiwrusrBNm+SSTsII8=; b=G2VzHdD4ucYDyOfYcf2YaTEpSNoyYjuAMLboKB1Mb5h3bbcTX3eEiUBn31rpT38IZ5i5wW kpOTaPoA2M1fFW3D1BuE1XdPQG5I8I7qCEU2WOp1/CBoYNskOMKJbbFkFCUmd0GGRcgJ+Q thb9GR4u1d89dvbxBmsQBXwMCCx9ixZEwEA363ihhqElKWHrB5UQ/Kibm6ZCWBSmDdbOIc FLl5DGp/TATt9sFZboFhPn7YoMTalX0VsvqLV9HxEgIQGJU9lzskJygaqR0ZKzpK506Q03 1z+SlvrWuaDTM2eUs+lel1dR4EslM10ZfkC4rOPa+oNu4oxXlfcNKTvYMCfhOA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1606168870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nOgyExsMmcgulCtYSfwEoyMOFUiwrusrBNm+SSTsII8=; b=jbjqZF8KCmxT1IFmm88MtvOgo8upRZm4W8+1DkcGTMq1ZlvrJhT6IqlcThSo8L0eKieRW3 +Z9+Jv/vrzKd2hCw== To: Alex Belits , "nitesh\@redhat.com" , "frederic\@kernel.org" Cc: Prasun Kapoor , "linux-api\@vger.kernel.org" , "davem\@davemloft.net" , "trix\@redhat.com" , "mingo\@kernel.org" , "catalin.marinas\@arm.com" , "rostedt\@goodmis.org" , "linux-kernel\@vger.kernel.org" , "peterx\@redhat.com" , "linux-arch\@vger.kernel.org" , "mtosatti\@redhat.com" , "will\@kernel.org" , "peterz\@infradead.org" , "leon\@sidebranch.com" , "linux-arm-kernel\@lists.infradead.org" , "pauld\@redhat.com" , "netdev\@vger.kernel.org" Subject: Re: [PATCH v5 3/9] task_isolation: userspace hard isolation from kernel In-Reply-To: <5d882681867ed43636e22d265d61afbbac1b5a62.camel@marvell.com> References: <8d887e59ca713726f4fcb25a316e1e932b02823e.camel@marvell.com> <5d882681867ed43636e22d265d61afbbac1b5a62.camel@marvell.com> Date: Mon, 23 Nov 2020 23:01:10 +0100 Message-ID: <878sarn36h.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alex, On Mon, Nov 23 2020 at 17:56, Alex Belits wrote: > .../admin-guide/kernel-parameters.txt | 6 + > drivers/base/cpu.c | 23 + > include/linux/hrtimer.h | 4 + > include/linux/isolation.h | 326 ++++++++ > include/linux/sched.h | 5 + > include/linux/tick.h | 3 + > include/uapi/linux/prctl.h | 6 + > init/Kconfig | 27 + > kernel/Makefile | 2 + > kernel/isolation.c | 714 ++++++++++++++++++ > kernel/signal.c | 2 + > kernel/sys.c | 6 + > kernel/time/hrtimer.c | 27 + > kernel/time/tick-sched.c | 18 + I asked you before to split this up into bits and pieces and argue and justify each change. Throwing this wholesale over the fence is going nowhere. It's not revieable at all. Aside of that ignoring review comments is a sure path to make yourself ignored: > +/* > + * Logging > + */ > +int task_isolation_message(int cpu, int level, bool supp, const char *fmt, ...); > + > +#define pr_task_isol_emerg(cpu, fmt, ...) \ > + task_isolation_message(cpu, LOGLEVEL_EMERG, false, fmt, ##__VA_ARGS__) The comments various people made about that are not going away and none of this is going near anything I'm responsible for unless you provide these independent of the rest and with a reasonable justification why you can't use any other existing mechanism or extend it for your use case. Thanks, tglx