From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00, BUG6152_INVALID_DATE_TZ_ABSURD,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,INVALID_DATE_TZ_ABSURD, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5F5C4363D for ; Thu, 24 Sep 2020 00:00:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D909821534 for ; Thu, 24 Sep 2020 00:00:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="NuBed+Cb"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="41KO66Nt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726706AbgIXAAP (ORCPT ); Wed, 23 Sep 2020 20:00:15 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:41578 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbgIXAAP (ORCPT ); Wed, 23 Sep 2020 20:00:15 -0400 From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1600905613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vIokpfgOjjX2X94R8YgU9FBZEr1sCciKtz6BI9Dgjr4=; b=NuBed+CbyPTz6q6GkbY+oo0HurFi64GYR3KAtvuNulbCDm4ymNlJORDPxiRRrerqpDF2pn pr4xdGvfruwgiA6SCWTxCwe3DQ5de/zEeMwOW8WI6EHZDsFEcYl8r66MQkKb+o2fve68iZ YaDlEiQgevwI8X7b++T7MyAx+/XPiD0tGHNbiZo4jmyS3EYwH4aANo5/yuJkdARQfhDXo8 Gn9pKndifKWa0kKEMAdb+sZv1KO+TR3OmGFmGSTnSL+UalV17O4AUIMMpl7jjufVyxAXJV yhemvIvo0IhOFcmClevGSmY01yDkSgzDOJaHGXbmgD2SLSqZAMcITRVNmjMDjg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1600905613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vIokpfgOjjX2X94R8YgU9FBZEr1sCciKtz6BI9Dgjr4=; b=41KO66NtD7BI13oS/ON6Z+pyQiFW41ScEgrFPva5Reb+E3Ny4P1Ze/VDV6N95eIR98qQB4 UjPQepo1Ue/1SEBA== To: Petr Mladek , Sergey Senozhatsky , Steven Rostedt Cc: Linus Torvalds , Thomas Gleixner , Prarit Bhargava , Mark Salyzyn , Chunyan Zhang , Orson Zhai , Changki Kim , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Petr Mladek Subject: Re: [PATCH 1/2] printk: Store all three timestamps In-Reply-To: <20200923135617.27149-2-pmladek@suse.com> References: <20200923135617.27149-1-pmladek@suse.com> <20200923135617.27149-2-pmladek@suse.com> Date: Thu, 24 Sep 2020 02:06:12 +0206 Message-ID: <878sd0m4c3.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-23, Petr Mladek wrote: > diff --git a/kernel/printk/printk_ringbuffer.h b/kernel/printk/printk_ringbuffer.h > index 0adaa685d1ca..09082c8472d3 100644 > --- a/kernel/printk/printk_ringbuffer.h > +++ b/kernel/printk/printk_ringbuffer.h > @@ -14,7 +15,7 @@ > */ > struct printk_info { > u64 seq; /* sequence number */ > - u64 ts_nsec; /* timestamp in nanoseconds */ > + struct ktime_timestamps ts; /* timestamps */ Until now struct printk_info has contained generic types. If we add struct ktime_timestamps, we may start storing more than we need. For example, if more (possibly internal) fields are added to struct ktime_timestamps that printk doesn't care about. We may prefer to generically and explicitly store the information we care about: u64 ts_mono; u64 ts_boot; u64 ts_real; Or create our own struct printk_ts to copy the fields of interest to. John Ogness