public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Mark Salyzyn <salyzyn@android.com>, linux-kernel@vger.kernel.org
Cc: kernel-team@android.com, Chiawei Wang <chiaweiwang@google.com>,
	Mark Salyzyn <salyzyn@android.com>,
	stable@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>
Subject: Re: [PATCH] lib/vdso: use CLOCK_REALTIME_COARSE for time()
Date: Thu, 11 Jun 2020 21:34:05 +0200	[thread overview]
Message-ID: <878sgt1jo2.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200611155804.65204-1-salyzyn@android.com>

Mark Salyzyn <salyzyn@android.com> writes:
> From: Chiawei Wang <chiaweiwang@google.com>
>
> CLOCK_REALTIME in vdso data won't be updated if
> __arch_use_vsyscall() returns false.

Errm!

# git grep __arch_use_vsyscall
#

Aside of that update_vsyscall() updates CLOCK_REALTIME data
unconditionally. No idea what this patch is solving.

> Cc: stable@vger.kernel.org # 5.4+

This # 5.4+ is pointless. You really want to add a fixes tag which pin
points the commit which introduced the wreckage.

But thats moot as this is not fixing anything not even in 5.4.

I assume this was developed against some Frankenkernel which has a messy
backport or a snapshot of some development version of that vdso stuff.

Not that I want to know, but please make sure that something you send my
way makes sense on sane kernels.

Oh well.

Thanks,

        tglx

  reply	other threads:[~2020-06-11 19:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 15:57 [PATCH] lib/vdso: use CLOCK_REALTIME_COARSE for time() Mark Salyzyn
2020-06-11 19:34 ` Thomas Gleixner [this message]
2020-06-11 19:47   ` Mark Salyzyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sgt1jo2.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=chiaweiwang@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=salyzyn@android.com \
    --cc=stable@vger.kernel.org \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox