Re: [RFC PATCH 4/5] selftest/x86: Fix sysret_rip with ENDBR

Yu-cheng Yu
2020-05-21T22:59:22Z

On Thu, 2020-05-21 at 23:34 +0200, Thomas Gleixner wrote:
> Yu-cheng Yu <yu-cheng.yu@intel.com> writes:
>
> > Insert endbr64 to assembly code of sysret_rip.
>
> This changelog explains what the patch does, but not the WHY. It also
> lacks any information why this is harmless for !CET enabled systems.
>
> > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
> > ---
>
> Please consult Dave Hansen about the void between your Signed-off-by
> and the '---' line.
>
> Thanks,
>
> tglx

Thanks! I will work on it.

Yu-cheng