Re: [patch 8/8] x86/entry: Move irqflags tracing to do_int80_syscall_32()

Thomas Gleixner
2020-02-28T13:49:59Z

Alexandre Chartre <alexandre.chartre@oracle.com> writes:
> On 2/25/20 11:08 PM, Thomas Gleixner wrote:
>> which cleans up the ASM maze.
>>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> ---
>> arch/x86/entry/common.c | 8 +++++++-
>> arch/x86/entry/entry_32.S | 9 ++-------
>> arch/x86/entry/entry_64_compat.S | 14 +++++---------
>> 3 files changed, 14 insertions(+), 17 deletions(-)
>>
>> --- a/arch/x86/entry/common.c
>> +++ b/arch/x86/entry/common.c
>> @@ -333,6 +333,7 @@ void do_syscall_64_irqs_on(unsigned long
>> {
>> syscall_entry_fixups();
>> do_syscall_64_irqs_on(nr, regs);
>> + trace_hardirqs_on();
>> }
>
> trace_hardirqs_on() is already called through syscall_return_slowpath()
> (from the previous patch):
>
> do_syscall_64()
> -> do_syscall_64_irqs_on()
> -> syscall_return_slowpath()
> -> trace_hardirqs_on()

Duh, indeed.