From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35770C3A5A3 for ; Tue, 27 Aug 2019 14:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 158A120828 for ; Tue, 27 Aug 2019 14:26:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728810AbfH0O0y convert rfc822-to-8bit (ORCPT ); Tue, 27 Aug 2019 10:26:54 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:6772 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726054AbfH0O0x (ORCPT ); Tue, 27 Aug 2019 10:26:53 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7REIen3072268; Tue, 27 Aug 2019 10:26:22 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 2un5cxu2ua-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Aug 2019 10:26:21 -0400 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.27/8.16.0.27) with SMTP id x7REJ5qK074678; Tue, 27 Aug 2019 10:26:21 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0b-001b2d01.pphosted.com with ESMTP id 2un5cxu2ty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Aug 2019 10:26:21 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x7REKVtU025745; Tue, 27 Aug 2019 14:26:20 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma02wdc.us.ibm.com with ESMTP id 2ujvv6g42b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Aug 2019 14:26:20 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7REQKqX52756946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Aug 2019 14:26:20 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B1F712405B; Tue, 27 Aug 2019 14:26:20 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BE4E9124053; Tue, 27 Aug 2019 14:26:19 +0000 (GMT) Received: from localhost (unknown [9.85.181.53]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 27 Aug 2019 14:26:19 +0000 (GMT) From: Nathan Lynch To: Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Allison Randal , Benjamin Herrenschmidt , Frank Rowand , Gen Zhang , Greg Kroah-Hartman , Michael Ellerman , "Oliver O'Halloran" , Paul Mackerras , Thomas Gleixner Subject: Re: [PATCH 1/2] powerpc/pseries: Delete an unnecessary kfree() call in dlpar_store() In-Reply-To: References: Date: Tue, 27 Aug 2019 09:26:19 -0500 Message-ID: <878sresn04.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-27_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=796 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908270153 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Markus Elfring writes: > From: Markus Elfring > Date: Tue, 27 Aug 2019 13:34:02 +0200 > > A null pointer would be passed to a call of the function “kfree” > immediately after a call of the function “kstrdup” failed at one place. > Remove this superfluous function call. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Nathan Lynch