From: John Ogness <john.ogness@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [RFC PATCH v3 2/2] printk-rb: add test module
Date: Wed, 31 Jul 2019 08:46:58 +0200 [thread overview]
Message-ID: <878ssen1jx.fsf@linutronix.de> (raw)
In-Reply-To: <20190727013333.11260-3-john.ogness@linutronix.de> (John Ogness's message of "Sat, 27 Jul 2019 03:33:33 +0200")
Add missing includes and exports.
Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
In case anyone wants to build/run my test module, this patch needs to
be applied. For my arm64 tests I need to build the module slightly
different, which is why I didn't catch this. Sorry.
Tested on 5.3-rc2.
kernel/printk/dataring.c | 1 +
kernel/printk/numlist.c | 1 +
kernel/printk/ringbuffer.c | 4 ++++
diff --git a/kernel/printk/dataring.c b/kernel/printk/dataring.c
index 911bac593ec1..6642e085a05d 100644
--- a/kernel/printk/dataring.c
+++ b/kernel/printk/dataring.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
+#include <linux/kernel.h>
#include "dataring.h"
/**
diff --git a/kernel/printk/numlist.c b/kernel/printk/numlist.c
index df3f89e7f7fd..d5e224dafc0c 100644
--- a/kernel/printk/numlist.c
+++ b/kernel/printk/numlist.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
+#include <linux/kernel.h>
#include <linux/sched.h>
#include "numlist.h"
diff --git a/kernel/printk/ringbuffer.c b/kernel/printk/ringbuffer.c
index 59bf59aba3de..b9fc13597b10 100644
--- a/kernel/printk/ringbuffer.c
+++ b/kernel/printk/ringbuffer.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
+#include <linux/kernel.h>
#include <linux/irqflags.h>
#include <linux/string.h>
#include <linux/err.h>
@@ -222,6 +223,7 @@ struct nl_node *prb_desc_node(unsigned long id, void *arg)
return &d->list;
}
+EXPORT_SYMBOL(prb_desc_node);
/**
* prb_desc_busy() - Numbered list callback to report if a node is busy.
@@ -262,6 +264,7 @@ bool prb_desc_busy(unsigned long id, void *arg)
/* hC: */
return (id == atomic_long_read(&d->id));
}
+EXPORT_SYMBOL(prb_desc_busy);
/**
* prb_getdesc() - Data ringbuffer callback to lookup a descriptor from an ID.
@@ -296,6 +299,7 @@ struct dr_desc *prb_getdesc(unsigned long id, void *arg)
/* iB: */
return &d->desc;
}
+EXPORT_SYMBOL(prb_getdesc);
/**
* assign_desc() - Assign a descriptor to the caller.
--
2.11.0
prev parent reply other threads:[~2019-07-31 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 1:33 [RFC PATCH v3 0/2] printk: new ringbuffer implementation John Ogness
2019-07-27 1:33 ` [RFC PATCH v3 1/2] printk-rb: add a new printk " John Ogness
2019-07-27 1:33 ` [RFC PATCH v3 2/2] printk-rb: add test module John Ogness
2019-07-31 6:46 ` John Ogness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ssen1jx.fsf@linutronix.de \
--to=john.ogness@linutronix.de \
--cc=andrea.parri@amarulasolutions.com \
--cc=brendanhiggins@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox