public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Borislav Petkov <bp@alien8.de>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Kosina <jikos@kernel.org>, Waiman Long <longman@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Jon Masters <jcm@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux-s390@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tyler Hicks <tyhicks@canonical.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH RFC 1/5] cpu/speculation: Add 'cpu_spec_mitigations=' cmdline options
Date: Fri, 12 Apr 2019 12:41:21 +1000	[thread overview]
Message-ID: <878swguer2.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20190411131540.754t5t4tp55i6vjq@treble>

Josh Poimboeuf <jpoimboe@redhat.com> writes:
> On Wed, Apr 10, 2019 at 02:10:01PM +0200, Thomas Gleixner wrote:
>> On Wed, 10 Apr 2019, Michael Ellerman wrote:
>> > Josh Poimboeuf <jpoimboe@redhat.com> writes:
>> > 
>> > > On Fri, Apr 05, 2019 at 06:01:36PM +0200, Borislav Petkov wrote:
>> > >> Thinking about this more, we can shave off the first 4 chars and have it
>> > >> be:
>> > >> 
>> > >> spec_mitigations=
>> > >> 
>> > >> I think it is painfully clear which speculation mitigations we mean. And
>> > >> the other switches don't have "cpu_" prefixes too so...
>> > >
>> > > Sure, I'm ok with renaming it to that, if there are no objections.
>> > 
>> > What about when we have a mitigation for a non-speculation related bug :)
>> 
>> Those kind of silicon bugs are usually mitigated unconditionally.
>
> Right.
>
> But at least "mitigations=" is nice and short.  We could clarify in the
> documentation that it doesn't apply to *all* mitigations, only the ones
> which are optional and which can affect performance.
>
> And it would give us the freedom to include any future "optional"
> mitigations, spec or not.
>
> I kind of like it.  But I could go either way.

Some of the published SMT attacks are not speculation based.

And arguably we already have an optional mitigation for those, ie. nosmt.

cheers

  reply	other threads:[~2019-04-12  2:41 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 16:44 [PATCH RFC 0/5] cpu/speculation: Add 'cpu_spec_mitigations=' cmdline options Josh Poimboeuf
2019-04-04 16:44 ` [PATCH RFC 1/5] " Josh Poimboeuf
2019-04-04 16:49   ` Josh Poimboeuf
2019-04-05 13:12   ` Borislav Petkov
2019-04-05 14:20     ` Josh Poimboeuf
2019-04-05 15:20       ` Borislav Petkov
2019-04-05 16:01         ` Borislav Petkov
2019-04-05 16:18           ` Josh Poimboeuf
2019-04-10  5:48             ` Michael Ellerman
2019-04-10  8:30               ` Borislav Petkov
2019-04-10 12:10               ` Thomas Gleixner
2019-04-11 13:15                 ` Josh Poimboeuf
2019-04-12  2:41                   ` Michael Ellerman [this message]
2019-04-12  2:29                 ` Michael Ellerman
2019-04-04 16:44 ` [PATCH RFC 2/5] x86/speculation: Add support for " Josh Poimboeuf
2019-04-05 13:57   ` Borislav Petkov
2019-04-05 14:31     ` Josh Poimboeuf
2019-04-05 15:26       ` Borislav Petkov
2019-04-05 16:05         ` Josh Poimboeuf
2019-04-05 15:18     ` Randy Dunlap
2019-04-05 15:30       ` Josh Poimboeuf
2019-04-04 16:44 ` [PATCH RFC 3/5] powerpc/speculation: " Josh Poimboeuf
2019-04-04 19:49   ` Jiri Kosina
2019-04-04 20:01     ` Timothy Pearson
2019-04-10  6:06   ` Michael Ellerman
2019-04-11  4:02     ` Josh Poimboeuf
2019-04-04 16:44 ` [PATCH RFC 4/5] s390/speculation: " Josh Poimboeuf
2019-04-04 16:44 ` [PATCH RFC 5/5] arm64/speculation: " Josh Poimboeuf
2019-04-05 14:39   ` Steven Price
2019-04-05 14:43     ` Josh Poimboeuf
2019-04-05 14:44   ` Will Deacon
2019-04-05 16:03     ` Josh Poimboeuf
2019-04-04 16:50 ` [PATCH RFC 0/5] cpu/speculation: Add " Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878swguer2.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=aarcange@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jcm@redhat.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=longman@redhat.com \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tyhicks@canonical.com \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox