* [BUG] cc5b114dcf bpf, i40e: add meta data support
@ 2018-06-12 16:17 Keith Busch
2018-06-12 20:24 ` Daniel Borkmann
0 siblings, 1 reply; 3+ messages in thread
From: Keith Busch @ 2018-06-12 16:17 UTC (permalink / raw)
To: intel-gfx, Daniel Borkmann, John Fastabend, Jeff Kirsher,
linux-kernel
My server's i40e no longer obtains an IP address on linux
mainline. Bisected to the following:
commit cc5b114dcf986bfd8e4c37bf65d1b7b1e5290ac6
Author: Daniel Borkmann <daniel@iogearbox.net>
Date: Mon May 28 11:07:20 2018 +0200
bpf, i40e: add meta data support
Reverting on mainline resolves the issue.
Is there something wrong with my i40e adapter, or is the patch possibly
doing something wrong? Or any other information I can get to help
understand why it's stopped working with this feature?
An excert from "journalctl -xe" on on the failing network adapter
is below.
Thanks,
Keith
---
Jun 12 10:04:35 localhost.localdomain dhclient[2632]: DHCPDISCOVER on eno1 to 255.255.255.255 port 67 interval 7 (xid=0x3b301712)
Jun 12 10:04:42 localhost.localdomain dhclient[2632]: DHCPDISCOVER on eno1 to 255.255.255.255 port 67 interval 14 (xid=0x3b301712)
Jun 12 10:04:56 localhost.localdomain dhclient[2632]: DHCPDISCOVER on eno1 to 255.255.255.255 port 67 interval 21 (xid=0x3b301712)
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <warn> [1528819503.2274] dhcp4 (eno1): request timed out
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2275] dhcp4 (eno1): state changed unknown -> timeout
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2440] dhcp4 (eno1): canceled DHCP transaction, DHCP client pid 2632
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2441] dhcp4 (eno1): state changed timeout -> done
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2445] device (eno1): state change: ip-config -> failed (reason 'ip-config-unavailable', internal state 'managed')
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2448] manager: NetworkManager state is now DISCONNECTED
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <warn> [1528819503.2452] device (eno1): Activation: failed for connection 'Wired connection 1'
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2460] device (eno1): state change: failed -> disconnected (reason 'none', internal state 'managed')
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2498] policy: auto-activating connection 'Wired connection 1'
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2517] device (eno1): Activation: starting connection 'Wired connection 1' (16a13ab5-c51e-361b-90bc-b6fc6f84cbe9)
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2520] device (eno1): state change: disconnected -> prepare (reason 'none', internal state 'managed')
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2523] manager: NetworkManager state is now CONNECTING
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info> [1528819503.2529] device (eno1): state change: prepare -> config (reason 'none', internal state 'managed')
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] cc5b114dcf bpf, i40e: add meta data support
2018-06-12 16:17 [BUG] cc5b114dcf bpf, i40e: add meta data support Keith Busch
@ 2018-06-12 20:24 ` Daniel Borkmann
2018-06-25 12:24 ` [Intel-gfx] " Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Borkmann @ 2018-06-12 20:24 UTC (permalink / raw)
To: Keith Busch, intel-gfx, John Fastabend, Jeff Kirsher,
linux-kernel
On 06/12/2018 06:17 PM, Keith Busch wrote:
> My server's i40e no longer obtains an IP address on linux
> mainline. Bisected to the following:
>
> commit cc5b114dcf986bfd8e4c37bf65d1b7b1e5290ac6
> Author: Daniel Borkmann <daniel@iogearbox.net>
> Date: Mon May 28 11:07:20 2018 +0200
>
> bpf, i40e: add meta data support
>
> Reverting on mainline resolves the issue.
>
> Is there something wrong with my i40e adapter, or is the patch possibly
> doing something wrong? Or any other information I can get to help
> understand why it's stopped working with this feature?
>
> An excert from "journalctl -xe" on on the failing network adapter
> is below.
Thanks for the report & sorry for the issue, Keith! Instead of revert,
could you give the below fix a try?
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 8ffb745..ed6dbcf 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -2103,9 +2103,8 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
unsigned int truesize = i40e_rx_pg_size(rx_ring) / 2;
#else
unsigned int truesize = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) +
- SKB_DATA_ALIGN(I40E_SKB_PAD +
- (xdp->data_end -
- xdp->data_hard_start));
+ SKB_DATA_ALIGN(xdp->data_end -
+ xdp->data_hard_start);
#endif
struct sk_buff *skb;
@@ -2124,7 +2123,7 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
return NULL;
/* update pointers within the skb to store the data */
- skb_reserve(skb, I40E_SKB_PAD + (xdp->data - xdp->data_hard_start));
+ skb_reserve(skb, xdp->data - xdp->data_hard_start);
__skb_put(skb, xdp->data_end - xdp->data);
if (metasize)
skb_metadata_set(skb, metasize);
Thanks,
Daniel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [BUG] cc5b114dcf bpf, i40e: add meta data support
2018-06-12 20:24 ` Daniel Borkmann
@ 2018-06-25 12:24 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2018-06-25 12:24 UTC (permalink / raw)
To: Daniel Borkmann, Keith Busch, John Fastabend, Jeff Kirsher,
linux-kernel, intel-wired-lan
FYI, the list you're looking for is likely intel-wired-lan (added), not
intel-gfx (removed).
BR,
Jani.
On Tue, 12 Jun 2018, Daniel Borkmann <daniel@iogearbox.net> wrote:
> On 06/12/2018 06:17 PM, Keith Busch wrote:
>> My server's i40e no longer obtains an IP address on linux
>> mainline. Bisected to the following:
>>
>> commit cc5b114dcf986bfd8e4c37bf65d1b7b1e5290ac6
>> Author: Daniel Borkmann <daniel@iogearbox.net>
>> Date: Mon May 28 11:07:20 2018 +0200
>>
>> bpf, i40e: add meta data support
>>
>> Reverting on mainline resolves the issue.
>>
>> Is there something wrong with my i40e adapter, or is the patch possibly
>> doing something wrong? Or any other information I can get to help
>> understand why it's stopped working with this feature?
>>
>> An excert from "journalctl -xe" on on the failing network adapter
>> is below.
>
> Thanks for the report & sorry for the issue, Keith! Instead of revert,
> could you give the below fix a try?
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> index 8ffb745..ed6dbcf 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> @@ -2103,9 +2103,8 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
> unsigned int truesize = i40e_rx_pg_size(rx_ring) / 2;
> #else
> unsigned int truesize = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) +
> - SKB_DATA_ALIGN(I40E_SKB_PAD +
> - (xdp->data_end -
> - xdp->data_hard_start));
> + SKB_DATA_ALIGN(xdp->data_end -
> + xdp->data_hard_start);
> #endif
> struct sk_buff *skb;
>
> @@ -2124,7 +2123,7 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
> return NULL;
>
> /* update pointers within the skb to store the data */
> - skb_reserve(skb, I40E_SKB_PAD + (xdp->data - xdp->data_hard_start));
> + skb_reserve(skb, xdp->data - xdp->data_hard_start);
> __skb_put(skb, xdp->data_end - xdp->data);
> if (metasize)
> skb_metadata_set(skb, metasize);
>
> Thanks,
> Daniel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-25 12:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-12 16:17 [BUG] cc5b114dcf bpf, i40e: add meta data support Keith Busch
2018-06-12 20:24 ` Daniel Borkmann
2018-06-25 12:24 ` [Intel-gfx] " Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox