From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756327AbdJLLvd convert rfc822-to-8bit (ORCPT ); Thu, 12 Oct 2017 07:51:33 -0400 Received: from mga11.intel.com ([192.55.52.93]:16840 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754802AbdJLLvc (ORCPT ); Thu, 12 Oct 2017 07:51:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,365,1503385200"; d="scan'208";a="161849399" From: Felipe Balbi To: Alexandre Torgue , Amelie DELAUNAY , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , John Youn Cc: "linux-usb\@vger.kernel.org" , "devicetree\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "linux-arm-kernel\@lists.infradead.org" , Benjamin GAIGNARD Subject: Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7 In-Reply-To: References: <1503930018-536-1-git-send-email-amelie.delaunay@st.com> <878tgim24i.fsf@linux.intel.com> <04a49088-b615-d7b8-0387-e7bfa32ee19f@st.com> <87vajllx8t.fsf@linux.intel.com> <1c4180ef-2da6-b420-7c6e-41769608384a@st.com> <87sheplsrm.fsf@linux.intel.com> <3c36db6d-75fd-1be6-e946-b75a04e3760e@st.com> <21df4d0c-075c-0c5a-c39b-b1dd94fe819d@st.com> <87efq821tz.fsf@linux.intel.com> Date: Thu, 12 Oct 2017 14:51:13 +0300 Message-ID: <878tgg1t5a.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Alexandre Torgue writes: > Hi Felipe > > On 10/12/2017 10:43 AM, Felipe Balbi wrote: >> >> Hi, >> >>>>>>>> >>>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote: >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Amelie Delaunay writes: >>>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is >>>>>>>>>> USB >>>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works >>>>>>>>>> with its >>>>>>>>>> internal phy whilst the USB HS core can work in HS with external >>>>>>>>>> ULPI phy >>>>>>>>>> or in FS/LS with the on-chip FS phy. >>>>>>>>>> >>>>>>>>>> Amelie Delaunay (7): >>>>>>>>>>      dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core >>>>>>>>>> binding >>>>>>>>>>      usb: dwc2: add support for STM32F7 USB OTG HS >>>>>>>>>>      ARM: dts: stm32: Add USB HS support for STM32F746 MCU >>>>>>>>> >>>>>>>>> I have applied these three patches. Should I take the rest? They >>>>>>>>> seems >>>>>>>>> like they could go upstream through the ARM maintainers. >>>>>>>>> >>>>>>>> >>>>>>>> I will take other DT patches in my PR. >>>>>>>> >>>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" >>>>>>>> patch >>>>>>>> I prefer also to take it. This patch adds some pinctrl groups but >>>>>>>> stm32 >>>>>>>> pinctrl bindings will change in my next PR (we will use a macro to >>>>>>>> define pins instead of using defined values). So if you push the DT >>>>>>>> patch through your pull request there will be a merge issue. >>>>>>>> It is possible that I take also this one ? >>>>>>> >>>>>>> In that case, it's best if you take them all :-) Here's my Ack: >>>>>>> >>>>>>> Acked-by: Felipe Balbi >>>>>>> >>>>>>> I'll drop them from my tree now >>>>>> >>>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2 >>>>>> in your tree. >>>>> >>>>> Well, I have dropped them from my tree. Please two 1-7 through yours. >>>> >>>> Hum, ok for this patchset but IMO it is better (next time) that you take >>>> driver pacthes in your tree and I take only DT patches in mine. >>>> No ? >>>> >>>> Regards >>>> Alex >>>> >>>>> >>> >>> I thought that patches 1 and 2, as they are "driver" patches, had to be >>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be >>> applied on STM32-DT tree (Alex's one). Did I miss something? >> >> patch 1 is documentation, right? Without the documentation patch, >> checkpatch will cringe :-) So either way works. >> >> If you insist, I can take 1-2 through my tree. No worries. > > I don't want to insist :) but for me it is better (and more safe) if you > take patch 1&2 in your tree, and will take others in mine. Okay, I'll apply 1&2 -- balbi