From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163129AbcG1G1p (ORCPT ); Thu, 28 Jul 2016 02:27:45 -0400 Received: from ozlabs.org ([103.22.144.67]:48434 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754732AbcG1G1h (ORCPT ); Thu, 28 Jul 2016 02:27:37 -0400 From: Rusty Russell To: Paul Gortmaker , linux-kernel@vger.kernel.org Cc: Paul Gortmaker Subject: Re: [PATCH] extable.h: add stddef.h so "NULL" definition is not implicit In-Reply-To: <20160728031147.26362-1-paul.gortmaker@windriver.com> References: <20160728031147.26362-1-paul.gortmaker@windriver.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 28 Jul 2016 15:24:39 +0930 Message-ID: <878twmz4rk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Gortmaker writes: > While not an issue now, eventually we will have independent users of > the extable.h file and we will stop sourcing it via module.h header. > > In testing that pending work, with very sparse builds, characteristic > of an "allnoconfig" on various architectures, we can sometimes hit an > instance where the very basic standard definitions aren't present, > resulting in: > > include/linux/extable.h:26:9: error: 'NULL' undeclared (first use in this function) > > To be clear, this isn't a regression, since currently extable.h is > only used by module.h -- however, we will need this addition present > before we start migrating exception table users off module.h and onto > extable.h during the next release cycle. > > Cc: Rusty Russell > Signed-off-by: Paul Gortmaker > --- > > [Was not expecting extable.h to be in 4.8 content, but since it is, it > might as well have this one line fixup to make it ready for 4.9 ; feel > free to squash this into the original extable.h creation if rebasing.] Applied. I prefer not to rebase published trees, and it's not like it's going to break anyone's bisect. Thanks, Rusty.