public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Linux Containers <containers@lists.linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Lutomirski <luto@amacapital.net>,
	Seth Forshee <seth.forshee@canonical.com>,
	Nikolay Borisov <kernel@kyup.com>,
	linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Jann Horn <jann@thejh.net>
Subject: Re: [PATCH v2 02/10] userns: Add per user namespace sysctls.
Date: Mon, 25 Jul 2016 19:02:01 -0500	[thread overview]
Message-ID: <878twp6zd2.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20160721164014.17534-2-ebiederm@xmission.com> (Eric W. Biederman's message of "Thu, 21 Jul 2016 11:40:06 -0500")

"Eric W. Biederman" <ebiederm@xmission.com> writes:

> Limit per userns sysctls to only be opened for write by a holder
> of CAP_SYS_RESOURCE.
>
> Add all of the necessary boilerplate for having per user namespace
> sysctls.

> @@ -141,6 +215,7 @@ void free_user_ns(struct user_namespace *ns)
>  
>  	do {
>  		parent = ns->parent;
> +		retire_userns_sysctls(ns);
^^^^^^^^^^ Unfortunately it is not safe to call a sleeping function here
           so this part needs to be taken back to the drawing board.
 
           Which means this change gets has to wait for next cycle.
>  #ifdef CONFIG_PERSISTENT_KEYRINGS
>  		key_put(ns->persistent_keyring_register);
>  #endif

Eric

  reply	other threads:[~2016-07-26  0:15 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8737n5dscy.fsf@x220.int.ebiederm.org>
2016-07-21 16:39 ` [PATCH v2 00/10] userns: sysctl limits for namespaces Eric W. Biederman
2016-07-21 16:40   ` [PATCH v2 01/10] sysctl: Stop implicitly passing current into sysctl_table_root.lookup Eric W. Biederman
2016-07-21 16:40     ` [PATCH v2 02/10] userns: Add per user namespace sysctls Eric W. Biederman
2016-07-26  0:02       ` Eric W. Biederman [this message]
2016-07-26  0:24         ` David Miller
2016-07-26  0:44           ` Eric W. Biederman
2016-07-26  2:58             ` David Miller
2016-07-26  4:00               ` Eric W. Biederman
2016-07-21 16:40     ` [PATCH v2 03/10] userns: Add a limit on the number of user namespaces Eric W. Biederman
2016-07-25 23:05       ` Serge E. Hallyn
2016-07-21 16:40     ` [PATCH v2 04/10] userns: Generalize the user namespace count into ucount Eric W. Biederman
2016-07-25 23:09       ` Serge E. Hallyn
2016-07-21 16:40     ` [PATCH v2 05/10] pidns: Add a limit on the number of pid namespaces Eric W. Biederman
2016-07-25 23:09       ` Serge E. Hallyn
2016-07-21 16:40     ` [PATCH v2 06/10] utsns: Add a limit on the number of uts namespaces Eric W. Biederman
2016-07-25 23:09       ` Serge E. Hallyn
2016-07-21 16:40     ` [PATCH v2 07/10] ipcns: Add a limit on the number of ipc namespaces Eric W. Biederman
2016-07-25 23:10       ` Serge E. Hallyn
2016-07-21 16:40     ` [PATCH v2 08/10] cgroupns: Add a limit on the number of cgroup namespaces Eric W. Biederman
2016-07-25 23:12       ` Serge E. Hallyn
2016-07-21 16:40     ` [PATCH v2 09/10] netns: Add a limit on the number of net namespaces Eric W. Biederman
2016-07-25 23:13       ` Serge E. Hallyn
2016-07-26  6:01       ` Andrei Vagin
2016-07-26 20:00         ` Eric W. Biederman
2016-07-21 16:40     ` [PATCH v2 10/10] mntns: Add a limit on the number of mount namespaces Eric W. Biederman
2016-07-25 23:15       ` Serge E. Hallyn
2016-07-22 13:33   ` [PATCH v2 00/10] userns: sysctl limits for namespaces Colin Walters
2016-07-22 18:45     ` Eric W. Biederman
2016-07-22 21:46       ` Kees Cook
2016-07-23  2:11         ` Eric W. Biederman
2016-07-26 10:27   ` Michael Kerrisk (man-pages)
2016-07-26 15:14     ` Eric W. Biederman
2016-07-26 10:30   ` Michael Kerrisk (man-pages)
2016-07-26 15:06     ` Eric W. Biederman
2016-07-26 16:52       ` Kees Cook
2016-07-26 17:29         ` Michael Kerrisk (man-pages)
2016-07-26 20:44           ` Kees Cook
2016-08-08 21:16   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878twp6zd2.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=jann@thejh.net \
    --cc=keescook@chromium.org \
    --cc=kernel@kyup.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=netdev@vger.kernel.org \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox