From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753488AbcGYQeO (ORCPT ); Mon, 25 Jul 2016 12:34:14 -0400 Received: from down.free-electrons.com ([37.187.137.238]:37799 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753174AbcGYQeL (ORCPT ); Mon, 25 Jul 2016 12:34:11 -0400 From: Gregory CLEMENT To: Mike Turquette Cc: Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Nadav Haklai , Victor Gu , Romain Perier , Omri Itach , Marcin Wojtas , Wilson Ding , Hua Jing , Terry Zhou Subject: Re: [PATCH v3 0/6] Add clock support for Armada 37xx SoCs References: <1468935742-11218-1-git-send-email-gregory.clement@free-electrons.com> Date: Mon, 25 Jul 2016 18:33:58 +0200 In-Reply-To: <1468935742-11218-1-git-send-email-gregory.clement@free-electrons.com> (Gregory CLEMENT's message of "Tue, 19 Jul 2016 15:42:16 +0200") Message-ID: <878twppthl.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike and Stephen, On mar., juil. 19 2016, Gregory CLEMENT wrote: > Hi, > > this is the third version of the series adding clock support for the > Armada 37xx SoCs. > > The main change is the use of static data for the peripheral clocks > when possible, it lead to a use of many macro to define all the needed > variables. > > The design of the drivers is as close as possible as the hardware is, > with some clocks made of several layers: muxing, divider and gating. > > The device tree binding was written in a way that even if we discover > some change inside the clocks, the binding should not be > affected. Especially, there are some holes in the clocks, but we > should be able to add them seamless. > > The full series is available on the branch Armada-3700-Clocks-v3 at > git@github.com:MISL-EBU-System-SW/mainline-public.git I think that with this series I took into account all the comments, do you think there is a chance that it will be merged in v4.8? Thanks, Gregory > > Thanks, > > Changelog: > > v2 -> v3 > > - used marvell,armada-3700-gpio instead of marvell,mvebu-gpio-3700 in > the binding as pointed by Thomas, > - removed the unnecessary include of clk.h in the 3 drivers, suggested > by Mike Turquette > - removed the modular reference in the 3 drivers, suggested by Paul > Gortmaker > - used static data for the peripheral driver when possible, suggested > by Mike Turquette > > v1 -> v2 > > - Move to clk_hw based registration for the 3 clock driver as > requested by Stephen Boyd > - Fixed typo noticed by Stephen Boyd > - Added const and static when they were missing: suggested by Stephen > Boyd > - Allocated the driver variable during probe instead of using a global > one as requested by Stephen Boyd > - Managed the failure of the of_clk_add_hw_provider call > - Added the Acked-by from Rob Herring on the dt binding patchs > > > > Gregory CLEMENT (6): > dt-bindings: clock: add DT binding for the Xtal clock on Armada 3700 > clk: mvebu: Add the xtal clock for Armada 3700 SoC > dt-bindings: clock: add DT binding for the TBG clocks on Armada 3700 > clk: mvebu Add the time base generator clocks for Armada 3700 > dt-bindings: clock: add DT binding for the peripheral clocks on Armada > 3700 > clk: mvebu: Add the peripheral clock driver for Armada 3700 > > .../bindings/clock/armada3700-periph-clock.txt | 70 ++++ > .../bindings/clock/armada3700-tbg-clock.txt | 27 ++ > .../bindings/clock/armada3700-xtal-clock.txt | 28 ++ > drivers/clk/mvebu/Kconfig | 3 + > drivers/clk/mvebu/Makefile | 3 + > drivers/clk/mvebu/armada-37xx-periph.c | 449 +++++++++++++++++++++ > drivers/clk/mvebu/armada-37xx-tbg.c | 158 ++++++++ > drivers/clk/mvebu/armada-37xx-xtal.c | 91 +++++ > 8 files changed, 829 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/armada3700-periph-clock.txt > create mode 100644 Documentation/devicetree/bindings/clock/armada3700-tbg-clock.txt > create mode 100644 Documentation/devicetree/bindings/clock/armada3700-xtal-clock.txt > create mode 100644 drivers/clk/mvebu/armada-37xx-periph.c > create mode 100644 drivers/clk/mvebu/armada-37xx-tbg.c > create mode 100644 drivers/clk/mvebu/armada-37xx-xtal.c > > -- > 2.5.0 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com