From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 5/8] net: dsa: mv88e6xxx: add switch register helpers
Date: Thu, 09 Jun 2016 08:53:53 -0400 [thread overview]
Message-ID: <878tyewmji.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <20160609023934.GK2227@lunn.ch>
Andrew Lunn <andrew@lunn.ch> writes:
> On Wed, Jun 08, 2016 at 08:44:53PM -0400, Vivien Didelot wrote:
>> Extract the allocation and registration code related to the dsa_switch
>> structure in a mv88e6xxx_register_switch helper function.
>>
>> For symmetry in the code, add a mv88e6xxx_unregister_switch function.
>
> You say what you are doing, but not why?
The mixed assignements and registrations in the probe code make it hard
to read and figure out what is dsa or chip specific, so I made that
change to provide a simple function doing one thing, make it easier to
follow the probe logic.
Thanks, I'll update the commit message.
Vivien
next prev parent reply other threads:[~2016-06-09 12:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 0:44 [PATCH net-next 0/8] net: dsa: mv88e6xxx: misc probe improvements Vivien Didelot
2016-06-09 0:44 ` [PATCH net-next 1/8] net: dsa: mv88e6xxx: fix style issues Vivien Didelot
2016-06-09 2:22 ` Andrew Lunn
2016-06-09 0:44 ` [PATCH net-next 2/8] net: dsa: mv88e6xxx: remove redundant assignments Vivien Didelot
2016-06-09 2:30 ` Andrew Lunn
2016-06-09 0:44 ` [PATCH net-next 3/8] net: dsa: mv88e6xxx: use already declared variables Vivien Didelot
2016-06-09 2:31 ` Andrew Lunn
2016-06-09 0:44 ` [PATCH net-next 4/8] net: dsa: mv88e6xxx: do not increment bus refcount Vivien Didelot
2016-06-09 2:36 ` Andrew Lunn
2016-06-10 19:59 ` Vivien Didelot
2016-06-10 20:06 ` Andrew Lunn
2016-06-09 0:44 ` [PATCH net-next 5/8] net: dsa: mv88e6xxx: add switch register helpers Vivien Didelot
2016-06-09 2:39 ` Andrew Lunn
2016-06-09 12:53 ` Vivien Didelot [this message]
2016-06-09 0:44 ` [PATCH net-next 6/8] net: dsa: mv88e6xxx: add chip detection helper Vivien Didelot
2016-06-09 0:44 ` [PATCH net-next 7/8] net: dsa: mv88e6xxx: explicit compatible devices Vivien Didelot
2016-06-09 2:14 ` Andrew Lunn
2016-06-10 20:26 ` Vivien Didelot
2016-06-09 0:44 ` [PATCH net-next 8/8] net: dsa: mv88e6xxx: fail on mismatching probe Vivien Didelot
2016-06-09 2:21 ` Andrew Lunn
2016-06-10 20:32 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tyewmji.fsf@ketchup.mtl.sfl \
--to=vivien.didelot@savoirfairelinux.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox