From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbbLJRdO (ORCPT ); Thu, 10 Dec 2015 12:33:14 -0500 Received: from smtp11.smtpout.orange.fr ([80.12.242.133]:25583 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754521AbbLJRdL (ORCPT ); Thu, 10 Dec 2015 12:33:11 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Thu, 10 Dec 2015 18:33:10 +0100 X-ME-IP: 92.156.1.80 From: Robert Jarzmik To: Linus Walleij Cc: Alexandre Courbot , Haojian Zhuang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Mack Subject: Re: [PATCH 4/4] gpio: pxa: add pin control gpio direction and request References: <1448746665-13422-1-git-send-email-robert.jarzmik@free.fr> <1448746665-13422-5-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 10 Dec 2015 18:33:10 +0100 In-Reply-To: <1448746665-13422-5-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sat, 28 Nov 2015 22:37:45 +0100") Message-ID: <878u52jjjd.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik writes: > +static int pxa_gpio_request(struct gpio_chip *chip, unsigned int offset) > +{ > + return pinctrl_request_gpio(chip->base + offset); > +} > + > +static void pxa_gpio_free(struct gpio_chip *chip, unsigned int offset) > +{ > + pinctrl_free_gpio(chip->base + offset); > +} This part will need a bit of rework : in the case of a platform data board, pinctrl_*() returns -EPROBE_DEFER, preventing any gpio user to claim a gpio. Either I hold with this patch to see how pxa pinctrl goes, or drop it, but in any case this one is not ready yet for merge. Cheers. -- Robert