From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932497AbbEOGgd (ORCPT ); Fri, 15 May 2015 02:36:33 -0400 Received: from mga11.intel.com ([192.55.52.93]:13300 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753954AbbEOGgc (ORCPT ); Fri, 15 May 2015 02:36:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,432,1427785200"; d="scan'208";a="726310829" From: Jani Nikula To: Liu Ying , dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, kernel@pengutronix.de, p.zabel@pengutronix.de, thierry.reding@gmail.com, shawn.guo@linaro.org, airlied@linux.ie, andyshrk@gmail.com, stefan.wahren@i2se.com, a.hajda@samsung.com, sboyd@codeaurora.org, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9.5.1 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format In-Reply-To: <1431570099-29216-1-git-send-email-Ying.Liu@freescale.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1431570099-29216-1-git-send-email-Ying.Liu@freescale.com> User-Agent: Notmuch/0.19+112~g77230b0 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Fri, 15 May 2015 09:34:54 +0300 Message-ID: <878ucqnyb5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 May 2015, Liu Ying wrote: > This patch adds a helper to get bits per pixel value of MIPI DSI pixel format. > The helper takes a parameter in the type 'enum mipi_dsi_pixel_format' and > returns it's bits per pixel value if the parameter is valid, otherwise, it > returns -EINVAL. The helper makes users' life easier to do the conversion > from a specific MIPI DSI pixel format to it's bits per pixel value. > > Signed-off-by: Liu Ying Reviewed-by: Jani Nikula > --- > v9.5->v9.5.1: > * To address Thierry Reding's comments, add a commit message to describe why > the helper is useful and when to use it and fix typo in kernel-doc from > 'mipi dsi' to 'MIPI DSI'. > > v9->v9.5: > * Add kernel-doc for the new helper function to address Daniel Vetter's > comment. > > v8->v9: > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. > > v7->v8: > * None. > > v6->v7: > * None. > > v5->v6: > * Address the over 80 characters in one line warning reported by the > checkpatch.pl script. > > v4->v5: > * None. > > v3->v4: > * None. > > v2->v3: > * None. > > v1->v2: > * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function > could be placed at the common DRM MIPI DSI driver. > This patch is newly added. > > include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f1d8d0d..186b15b 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev) > return container_of(dev, struct mipi_dsi_device, dev); > } > > +/** > + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a MIPI DSI > + * pixel format > + * @fmt: MIPI DSI pixel format > + * > + * Return: The bits per pixel value for the MIPI DSI pixel format on success or > + * a negative error code on failure. > + */ > +static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) > +{ > + switch (fmt) { > + case MIPI_DSI_FMT_RGB888: > + case MIPI_DSI_FMT_RGB666: > + return 24; > + case MIPI_DSI_FMT_RGB666_PACKED: > + return 18; > + case MIPI_DSI_FMT_RGB565: > + return 16; > + } > + return -EINVAL; > +} > + > struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np); > int mipi_dsi_attach(struct mipi_dsi_device *dsi); > int mipi_dsi_detach(struct mipi_dsi_device *dsi); > -- > 1.9.1 > -- Jani Nikula, Intel Open Source Technology Center