public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: perf tools: Question about kmem and kernel symbol resolution
Date: Fri, 01 Aug 2014 14:43:48 +0900	[thread overview]
Message-ID: <878un8hii3.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140731142711.GX7831@kernel.org> (Arnaldo Carvalho de Melo's message of "Thu, 31 Jul 2014 11:27:11 -0300")

On Thu, 31 Jul 2014 11:27:11 -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jul 31, 2014 at 05:35:32PM +0900, Namhyung Kim escreveu:
>> I'm looking kernel symbol mismatch issue, and found something in perf
>> kmem code.  The commit e727ca73f85d ("perf kmem: Resolve kernel
>> symbols again") added perf_session__create_kernel_maps() but I don't
>> know why.  Why did it miss the MMAP event?
>  
>> I think if we create a kernel maps at report time, it might not match
>> to samples in a perf.data if it's recorded on a different kernel.
>> This is the main reason of the mismatch problem I'm currently chasing
>> IMHO.  What am I missing?
>
>> From a quick look, nothing, i.e. we can not call
> perf_session__create_kernel_maps() at that point, as it will create the
> kernel maps from the running kernel and use it with events from the
> kernel that was in place when the perf.data file being processed was
> created.
>
> Perhaps that problem was fixed somewhere else and we should just revert
> that patch?
>
> Have you tried just reverting it and checking that the results are the
> expected ones? I.e. that there is the kernel MMAP event in perf.data
> file and that it gets properly processed?

Simply reverting ended up with no symbols but it contains MMAP event for
sure.

Then I found a reason - it's simply because kmem tools doesn't register
mmap event handlers. :-/  Adding mmap[2] handlers + reverting ended up
with the expected output.

I'll send the fix soon.

Thanks,
Namhyung

      reply	other threads:[~2014-08-01  5:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31  8:35 perf tools: Question about kmem and kernel symbol resolution Namhyung Kim
2014-07-31 14:27 ` Arnaldo Carvalho de Melo
2014-08-01  5:43   ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878un8hii3.fsf@sejong.aot.lge.com \
    --to=namhyung@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox