* Comment added in 63662139e "params: Fix potential memory leak in add_sysfs_param()"
@ 2014-03-21 12:46 Rasmus Villemoes
0 siblings, 0 replies; only message in thread
From: Rasmus Villemoes @ 2014-03-21 12:46 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-kernel
Hi,
I'm not at all convinced by the comment added in commit
63662139e519ce. If krealloc(attrs, ...) fails, nothing seems to free attrs;
the krealloc() call certainly doesn't do it. If attrs was NULL to begin
with, no harm done, but otherwise it is "attrs = mk->mp->grp.attrs;",
and mk->mp is NULL'ed on the error path fail_free_new: (and the value of
mk->mp is anyway invalidated by the krealloc() above).
Am I missing something?
Rasmus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-03-21 12:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-21 12:46 Comment added in 63662139e "params: Fix potential memory leak in add_sysfs_param()" Rasmus Villemoes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox