From: "Bjørn Mork" <bjorn@mork.no>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
fangxiaozhi@huawei.com, zihan@huawei.com, Lin.Lei@huawei.com,
Greg KH <gregkh@linuxfoundation.org>,
neil.yi@huawei.com, wangyuhua@huawei.com, huqiao36@huawei.com,
balbi@ti.com, mdharm-usb@one-eyed-alien.net,
sebastian@breakpoint.cc, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] USB: storage: fix Huawei mode switching regression
Date: Mon, 04 Mar 2013 17:47:01 +0100 [thread overview]
Message-ID: <878v63ru2i.fsf@nemi.mork.no> (raw)
In-Reply-To: <1362407359.3768.337.camel@deadeye.wl.decadent.org.uk> (Ben Hutchings's message of "Mon, 04 Mar 2013 14:29:19 +0000")
Ben Hutchings <ben@decadent.org.uk> writes:
> On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote:
> [...]
>> In-kernel mode switching was deprecated years ago with the
>> development of the more user friendly userspace alternatives. The
>> existing list of devices in usb-storage was only kept to prevent
>> breaking already working systems. The long term plan is to remove
>> the list, not to add to it. Ref:
>> http://permalink.gmane.org/gmane.linux.usb.general/28543
> [...]
>
> Can you add a comment to this effect?
In the table in unusual_devs.h, you mean? Sure, I can do that.
But it feels a bit strange since I can only quote and/or refer to what
Matthew and Greg said about the issue years ago. Putting a comment in
the code to remind the current maintainers about their own statements
could be considered out of line? Or is this appropriate here?
Bjørn
next prev parent reply other threads:[~2013-03-04 16:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 7:16 [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command fangxiaozhi 00110321
2013-03-04 11:41 ` v3.8 regression: Huawei mode switching fails (was Re: [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command) Bjørn Mork
2013-03-04 13:19 ` [PATCH] USB: storage: fix Huawei mode switching regression Bjørn Mork
2013-03-04 14:29 ` Ben Hutchings
2013-03-04 16:47 ` Bjørn Mork [this message]
2013-03-04 16:59 ` Matthew Dharm
2013-03-04 19:22 ` Bjørn Mork
2013-03-04 22:28 ` Josua Dietze
2013-03-05 8:32 ` Oliver Neukum
2013-03-05 11:35 ` Bjørn Mork
2013-03-05 2:15 ` Fangxiaozhi (Franko)
2013-03-05 10:07 ` Bjørn Mork
2013-03-05 11:52 ` Oliver Neukum
2013-03-05 14:08 ` Bjørn Mork
2013-03-06 1:34 ` 答复: " Linlei (Lei Lin)
2013-03-06 1:44 ` Greg KH
2013-03-06 15:45 ` Dan Williams
2013-03-07 2:54 ` Fangxiaozhi (Franko)
2013-03-07 3:18 ` Greg KH
2013-03-07 12:19 ` Bjørn Mork
2013-03-07 14:11 ` Josua Dietze
2013-03-05 2:28 ` v3.8 regression: Huawei mode switching fails (was Re: [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command) Fangxiaozhi (Franko)
2013-03-05 8:48 ` Oliver Neukum
2013-03-05 9:05 ` Fangxiaozhi (Franko)
2013-03-05 12:23 ` Bjørn Mork
2013-03-06 1:40 ` greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v63ru2i.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=Lin.Lei@huawei.com \
--cc=balbi@ti.com \
--cc=ben@decadent.org.uk \
--cc=fangxiaozhi@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=huqiao36@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=neil.yi@huawei.com \
--cc=sebastian@breakpoint.cc \
--cc=stable@vger.kernel.org \
--cc=wangyuhua@huawei.com \
--cc=zihan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox