From: Andi Kleen <andi@firstfloor.org>
To: Sage Weil <sage@newdream.net>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 17/19] ceph: ioctls
Date: Thu, 23 Jul 2009 00:39:25 +0200 [thread overview]
Message-ID: <878wig2vhe.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1248292313-31326-18-git-send-email-sage@newdream.net> (Sage Weil's message of "Wed, 22 Jul 2009 12:51:51 -0700")
Sage Weil <sage@newdream.net> writes:
> A few Ceph ioctls for getting and setting file layout (striping)
> parameters.
It would be good if you posted manpages for these ioctls
so that the interface can be reviewed. After all
that's intended to be used by applications, isn't it?
There don't seem to be compat ioctl handlers?
> diff --git a/fs/ceph/ioctl.h b/fs/ceph/ioctl.h
> new file mode 100644
> index 0000000..537c27b
> --- /dev/null
> +++ b/fs/ceph/ioctl.h
> @@ -0,0 +1,12 @@
> +#ifndef FS_CEPH_IOCTL_H
> +#define FS_CEPH_IOCTL_H
> +
> +#include <linux/ioctl.h>
> +#include "types.h"
> +
> +#define CEPH_IOCTL_MAGIC 0x97
> +
> +#define CEPH_IOC_GET_LAYOUT _IOR(CEPH_IOCTL_MAGIC, 1, struct ceph_file_layout)
> +#define CEPH_IOC_SET_LAYOUT _IOW(CEPH_IOCTL_MAGIC, 2, struct ceph_file_layout)
How should the application use that if the include file is in fs/ceph?
Should be in include/linux I guess
Also this file should define all the types needed for the interface,
especialy struct ceph_file_layout, but no kernel internal types.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-07-22 22:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 19:51 [PATCH 00/19] ceph: Ceph distributed file system client v0.11 Sage Weil
2009-07-22 19:51 ` [PATCH 01/19] ceph: documentation Sage Weil
2009-07-22 19:51 ` [PATCH 02/19] ceph: on-wire types Sage Weil
2009-07-22 19:51 ` [PATCH 03/19] ceph: client types Sage Weil
2009-07-22 19:51 ` [PATCH 04/19] ceph: super.c Sage Weil
2009-07-22 19:51 ` [PATCH 05/19] ceph: inode operations Sage Weil
2009-07-22 19:51 ` [PATCH 06/19] ceph: directory operations Sage Weil
2009-07-22 19:51 ` [PATCH 07/19] ceph: file operations Sage Weil
2009-07-22 19:51 ` [PATCH 08/19] ceph: address space operations Sage Weil
2009-07-22 19:51 ` [PATCH 09/19] ceph: MDS client Sage Weil
2009-07-22 19:51 ` [PATCH 10/19] ceph: OSD client Sage Weil
2009-07-22 19:51 ` [PATCH 11/19] ceph: CRUSH mapping algorithm Sage Weil
2009-07-22 19:51 ` [PATCH 12/19] ceph: monitor client Sage Weil
2009-07-22 19:51 ` [PATCH 13/19] ceph: capability management Sage Weil
2009-07-22 19:51 ` [PATCH 14/19] ceph: snapshot management Sage Weil
2009-07-22 19:51 ` [PATCH 15/19] ceph: messenger library Sage Weil
2009-07-22 19:51 ` [PATCH 16/19] ceph: nfs re-export support Sage Weil
2009-07-22 19:51 ` [PATCH 17/19] ceph: ioctls Sage Weil
2009-07-22 19:51 ` [PATCH 18/19] ceph: debugfs Sage Weil
2009-07-22 19:51 ` [PATCH 19/19] ceph: Kconfig, Makefile Sage Weil
2009-07-25 5:31 ` [PATCH 18/19] ceph: debugfs Greg KH
2009-07-27 17:06 ` Sage Weil
2009-07-22 22:39 ` Andi Kleen [this message]
2009-07-22 23:52 ` [PATCH 17/19] ceph: ioctls Sage Weil
2009-07-23 6:24 ` Andi Kleen
2009-07-23 18:42 ` Sage Weil
2009-07-23 10:25 ` [PATCH 08/19] ceph: address space operations Andi Kleen
2009-07-23 18:22 ` Sage Weil
2009-07-23 19:16 ` Andi Kleen
2009-07-24 4:48 ` Sage Weil
2009-07-23 19:17 ` Andi Kleen
2009-07-23 18:26 ` Sage Weil
2009-07-23 18:47 ` Trond Myklebust
2009-07-24 4:44 ` Sage Weil
2009-07-24 6:56 ` Andi Kleen
2009-07-24 16:52 ` Sage Weil
2009-07-24 19:40 ` J. Bruce Fields
-- strict thread matches above, loose matches on Subject: below --
2009-08-05 22:30 [PATCH 00/19] ceph distributed file system client Sage Weil
2009-08-05 22:30 ` [PATCH 01/19] ceph: documentation Sage Weil
2009-08-05 22:30 ` [PATCH 02/19] ceph: on-wire types Sage Weil
2009-08-05 22:30 ` [PATCH 03/19] ceph: client types Sage Weil
2009-08-05 22:30 ` [PATCH 04/19] ceph: super.c Sage Weil
2009-08-05 22:30 ` [PATCH 05/19] ceph: inode operations Sage Weil
2009-08-05 22:30 ` [PATCH 06/19] ceph: directory operations Sage Weil
2009-08-05 22:30 ` [PATCH 07/19] ceph: file operations Sage Weil
2009-08-05 22:30 ` [PATCH 08/19] ceph: address space operations Sage Weil
2009-08-05 22:30 ` [PATCH 09/19] ceph: MDS client Sage Weil
2009-08-05 22:30 ` [PATCH 10/19] ceph: OSD client Sage Weil
2009-08-05 22:30 ` [PATCH 11/19] ceph: CRUSH mapping algorithm Sage Weil
2009-08-05 22:30 ` [PATCH 12/19] ceph: monitor client Sage Weil
2009-08-05 22:30 ` [PATCH 13/19] ceph: capability management Sage Weil
2009-08-05 22:30 ` [PATCH 14/19] ceph: snapshot management Sage Weil
2009-08-05 22:30 ` [PATCH 15/19] ceph: messenger library Sage Weil
2009-08-05 22:30 ` [PATCH 16/19] ceph: nfs re-export support Sage Weil
2009-08-05 22:30 ` [PATCH 17/19] ceph: ioctls Sage Weil
2009-08-06 15:41 ` Andi Kleen
2009-08-06 17:04 ` Sage Weil
2008-11-14 0:55 [PATCH 00/19] ceph: Ceph distributed file system client Sage Weil
2008-11-14 0:56 ` [PATCH 01/19] ceph: documentation Sage Weil
2008-11-14 0:56 ` [PATCH 02/19] ceph: on-wire types Sage Weil
2008-11-14 0:56 ` [PATCH 03/19] ceph: client types Sage Weil
2008-11-14 0:56 ` [PATCH 04/19] ceph: super.c Sage Weil
2008-11-14 0:56 ` [PATCH 05/19] ceph: inode operations Sage Weil
2008-11-14 0:56 ` [PATCH 06/19] ceph: directory operations Sage Weil
2008-11-14 0:56 ` [PATCH 07/19] ceph: file operations Sage Weil
2008-11-14 0:56 ` [PATCH 08/19] ceph: address space operations Sage Weil
2008-11-14 0:56 ` [PATCH 09/19] ceph: MDS client Sage Weil
2008-11-14 0:56 ` [PATCH 10/19] ceph: OSD client Sage Weil
2008-11-14 0:56 ` [PATCH 11/19] ceph: CRUSH mapping algorithm Sage Weil
2008-11-14 0:56 ` [PATCH 12/19] ceph: monitor client Sage Weil
2008-11-14 0:56 ` [PATCH 13/19] ceph: capability management Sage Weil
2008-11-14 0:56 ` [PATCH 14/19] ceph: snapshot management Sage Weil
2008-11-14 0:56 ` [PATCH 15/19] ceph: messenger library Sage Weil
2008-11-14 0:56 ` [PATCH 16/19] ceph: nfs re-export support Sage Weil
2008-11-14 0:56 ` [PATCH 17/19] ceph: ioctls Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wig2vhe.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox