Re: [PATCH 2.5.54] hermes: serialization fixes

Benjamin LaHaise
2003-01-03T17:40:52Z

On Fri, Jan 03, 2003 at 12:39:29PM -0500, Stephen Evanchik wrote:
> The hermes MAC controller module wasn't serializing BAP seek calls. This
> caused an eventual Rx/Tx failure which equates tens of thousands of errors on
> the wireless interface. A simple spinlock is used to keep things in line.
>
> Any comments are appreciated, I don't believe this is the best solution, but
> it is working well. Patches can be downloaded from here:

Why not put the spinlock/unlock inside hermes_bap_seek()? Smaller, better
contained and more readable.

-ben