The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: YuanZhe Liu <25031212351@stu.xidian.edu.cn>
Cc: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Bin Yu <byu@xidian.edu.cn>,
	Cheng Wen <wencheng@xidian.edu.cn>
Subject: Re: [PATCH v3] ALSA: line6: Kill URBs before releasing the PCM buffer
Date: Sun, 22 Nov 2026 09:16:26 +0100	[thread overview]
Message-ID: <87a4n1702t.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261121104000.5431-1-25031212351@stu.xidian.edu.cn>

On Sat, 21 Nov 2026 11:40:00 +0100,
YuanZhe Liu wrote:
> 
> line6_buffer_release() frees the stream buffer after
> line6_wait_clear_audio_urbs() gave up waiting for the URBs that are still
> active.  The buffer is still referenced by those URBs, and the completion
> callback of such an URB resubmits it from submit_audio_out_urb() with
> line6pcm->out.buffer already set to NULL, which ends up in a NULL pointer
> dereference in the memset() in submit_audio_out_urb().
> 
> While the URBs remain queued, the host controller can also write the
> received isochronous data into the freed buffer.  Such a write does not go
> through the KASAN checks, so it silently corrupts the freed slab object;
> the corruption was observed as a bogus KASAN quarantine entry that later
> led to a general protection fault in qlist_free_all().
> 
> The active_urbs bitmap cannot prove that the URBs are gone:
> line6_unlink_audio_urbs() is called outside the stream lock and only marks
> the URBs that are active at that moment, so an URB resubmitted by a
> completion callback right after the scan is never unlinked and keeps being
> resubmitted after the stream was stopped.
> 
> Set the unlink bit for every currently active URB under the stream lock,
> so that the completion callbacks cannot resubmit them, and then kill all
> URBs synchronously.  usb_kill_urb() waits for the giveback, hence the
> buffer is no longer referenced by any URB when it is freed.  Drop the
> unlink marks afterwards: line6_unlink_audio_urbs() can leave a stale mark
> on an URB that completed and was not resubmitted, and such a mark makes
> line6_stream_start() skip submitting the URBs.
> 
> Fixes: 63e20df1e5b2 ("ALSA: line6: Reorganize PCM stream handling")
> Cc: stable@vger.kernel.org
> Co-developed-by: Bin Yu <byu@xidian.edu.cn>
> Signed-off-by: Bin Yu <byu@xidian.edu.cn>
> Co-developed-by: Cheng Wen <wencheng@xidian.edu.cn>
> Signed-off-by: Cheng Wen <wencheng@xidian.edu.cn>
> Signed-off-by: YuanZhe Liu <25031212351@stu.xidian.edu.cn>

Thanks for the patch.

But, this kind of synchronization should be rather done in sync_stop
PCM ops that seems missing in the current LINE6 driver.
 
I guess line6_wait_clear_audio_urbs() could be replaced with
usb_kill_urb() as you've done, and move it to sync_stop callback.
Then it can be dropped from snd_line6_prepare() and
line6_pcm_acquire().  line6_pcm_disconnect() still might need it,
though.


Takashi

> v3:
> - Kill the URBs unconditionally instead of rechecking active_urbs outside
>   the stream lock, and clear the unlink marks after the kills.
> 
> v2:
> - Rebased on sound/for-next.  v1 was generated against v7.3.1 and no longer
>   applied, because line6_buffer_release() gained the prev_fbuf clearing
>   block in the meantime.  No code change.
> ---
>  sound/usb/line6/pcm.c | 32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/usb/line6/pcm.c b/sound/usb/line6/pcm.c
> index d17baf7761c6..4be3b41a98a2 100644
> --- a/sound/usb/line6/pcm.c
> +++ b/sound/usb/line6/pcm.c
> @@ -134,6 +134,36 @@ static void line6_wait_clear_audio_urbs(struct snd_line6_pcm *line6pcm,
>  			"timeout: still %d active urbs..\n", alive);
>  }
>  
> +/*
> + * Mark all currently active URBs for unlinking and kill them.
> + *
> + * The unlink bit is set under the stream lock, so the completion
> + * callbacks cannot resubmit these URBs any longer.  usb_kill_urb() then
> + * waits for the giveback of every URB, hence the stream buffer is no
> + * longer referenced by the host controller.  The unlink marks are
> + * cleared afterwards, so that a later stream start can submit the URBs
> + * again.  This function must be called from a sleepable context.
> + */
> +static void line6_kill_audio_urbs(struct snd_line6_pcm *line6pcm,
> +				  struct line6_pcm_stream *pcms)
> +{
> +	int i;
> +
> +	scoped_guard(spinlock_irqsave, &pcms->lock) {
> +		for (i = 0; i < line6pcm->line6->iso_buffers; i++)
> +			if (test_bit(i, &pcms->active_urbs))
> +				set_bit(i, &pcms->unlink_urbs);
> +	}
> +
> +	for (i = 0; i < line6pcm->line6->iso_buffers; i++)
> +		if (pcms->urbs[i])
> +			usb_kill_urb(pcms->urbs[i]);
> +
> +	scoped_guard(spinlock_irqsave, &pcms->lock) {
> +		pcms->unlink_urbs = 0;
> +	}
> +}
> +
>  static inline struct line6_pcm_stream *
>  get_stream(struct snd_line6_pcm *line6pcm, int direction)
>  {
> @@ -172,7 +202,7 @@ static void line6_buffer_release(struct snd_line6_pcm *line6pcm,
>  {
>  	clear_bit(type, &pstr->opened);
>  	if (!pstr->opened) {
> -		line6_wait_clear_audio_urbs(line6pcm, pstr);
> +		line6_kill_audio_urbs(line6pcm, pstr);
>  		if (pstr == &line6pcm->in) {
>  			/* prev_fbuf points into the capture buffer we are about
>  			 * to free; drop it while no capture URB is in flight.
> -- 
> 2.34.1
> 

      reply	other threads:[~2026-11-22  8:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 10:40 [PATCH v3] ALSA: line6: Kill URBs before releasing the PCM buffer YuanZhe Liu
2026-11-22  8:16 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a4n1702t.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=25031212351@stu.xidian.edu.cn \
    --cc=byu@xidian.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=stable@vger.kernel.org \
    --cc=wencheng@xidian.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox