The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: propagate BBT read transport errors
Date: Wed, 18 Nov 2026 10:59:57 +0100	[thread overview]
Message-ID: <87a4n6jw82.fsf@bootlin.com> (raw)
In-Reply-To: <20261103-submit-rawnand-bbt-read-error-v1-v1-1-2ff0abffaf2e@gmail.com> (James Hilliard's message of "Tue, 03 Nov 2026 23:03:39 -0700")

On 03/11/2026 at 23:03:39 -07, James Hilliard <james.hilliard1@gmail.com> wrote:

> check_create() handles uncorrectable ECC errors by invalidating the
> affected BBT copy and handles corrected errors by scheduling a rewrite.
> Other read_abs_bbt() failures are ignored, allowing initialization to
> succeed with missing entries in the RAM table or to rewrite a table that
> was not completely read.
>
> Return non-ECC read errors from both the selected table and the second
> unversioned copy before updating versions or writing tables. A transport
> failure does not establish that the selected table is corrupt or that an
> older mirror contains all of its bad-block information. Preserve the
> existing ECC-specific recovery paths.

Be honest, you did not read that back. I don't think one would guess the
big picture by reading this. Here is a proposal:

```
ECC failures have dedicated recovery paths: -EBADMSG invalidates the
affected copy and -EUCLEAN schedules a scrub. Any other read error
(typically an I/O error) would be unhandled and leave the RAM table
incomplete.

Make sure those errors are propagated.
```

Thanks,
Miquèl

      reply	other threads:[~2026-11-18 10:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  6:03 [PATCH] mtd: rawnand: propagate BBT read transport errors James Hilliard
2026-11-18  9:59 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a4n6jw82.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=james.hilliard1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox