From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B25943EDAAC for ; Fri, 8 May 2026 14:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778250153; cv=none; b=gs9WrIg7an9XxRF3zlvHff2HMNCYypVL97HfwK1npsBSFJC5lxGyEbkUOX0IJDc0XL9vJJNQXwv/ZAudA2lXuvrk9c3bX48wV1009MRBgGKke//R340lo42WCGl/cupIpJWNS/CgaTJm6O7EMgT6NtgCRAcASquu1107OVi/6bY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778250153; c=relaxed/simple; bh=4zHvuFXQADKjJd5iPTk8ZZtbpzGGp8TJR2VJwLx8tOA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=L+1lWjO+zpXNX6bp7t50kZxPGw+Lfp/hXlkZaVG6RfTTI/sj/iey7lYb5LvYa9/KJ9N402/+d3YFjKZK6QqF7Ftj4kqSvumZazkEoBk2UbxAemr58OZOdSfYaCrNZuaGDLH4iFJEIoXupJvExk+ViKv4zaeuwn3j8aBZJrM0uG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=stEpEUnE; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=sXcoWR2+; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="stEpEUnE"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="sXcoWR2+" From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1778250149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GVgZd3leqq0VYLF37DKFHIxYSMYCANcK28x24C0+v80=; b=stEpEUnESHAMpZ2SIGnUq9Zw9+aHE3SbIdYHD9fi5R8RGx63X7ct7arKzecfLeOE1TF/kA QRh4Xw4cPJkVe3T45hRM/bLKvE9lzkp2TjaXStNGsctyswKv1tZJuxf8RjKZ8bVL18y2ZG MlV8brmAfMxAeA7VijL12uaE5zftVxesgjl1SjTvcHFDgZbriQxayNPkGLvpz25e2aNkrP r3pMzHIb9rhrRh6GCOzq8NAkwPDcnytPuBnr9+12XbJrN/m7hg/jkBhrWp2/I+DeRPU81Z UtswhrbYOuU4fgiJQ3PBuP0wv4nNGmoEB4JY3ymjcCW43UvZMkHUfGjxyoMNNw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1778250149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GVgZd3leqq0VYLF37DKFHIxYSMYCANcK28x24C0+v80=; b=sXcoWR2+upeV4CDOGhyvc+hRly+TDQTBbF5yVrvDr5uWlL2THZcESEpI9txI7XkFOWHod/ yxNOAh/869pukoCA== To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , Chris Down , linux-kernel@vger.kernel.org, Petr Mladek Subject: Re: [PATCH v2 1/9] printk: Rename struct console_cmdline to preferred_console In-Reply-To: <20260423130015.85175-2-pmladek@suse.com> References: <20260423130015.85175-1-pmladek@suse.com> <20260423130015.85175-2-pmladek@suse.com> Date: Fri, 08 May 2026 16:28:29 +0206 Message-ID: <87a4uaf0be.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 2026-04-23, Petr Mladek wrote: > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index 0323149548f6..ca523acbf58d 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -2624,8 +2624,10 @@ __setup("console_msg_format=", console_msg_format_setup); > */ > static int __init console_setup(char *str) > { > - static_assert(sizeof(console_cmdline[0].devname) >= sizeof(console_cmdline[0].name) + 4); > - char buf[sizeof(console_cmdline[0].devname)]; > + static_assert(sizeof(preferred_consoles[0].devname) >= > + sizeof(preferred_consoles[0].name) + 4); > + > + char buf[sizeof(preferred_consoles[0].devname)]; I agree with Steven's suggestion to move the static_assert() below the local variable definitions. Reviewed-by: John Ogness