From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: i2c: ak4xxx-adda: seed AK5365 cache with reset defaults
Date: Thu, 09 Apr 2026 12:01:30 +0200 [thread overview]
Message-ID: <87a4vcjvut.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260408-ak5365-cache-defaults-v1-1-fff639aca3e3@gmail.com>
On Wed, 08 Apr 2026 17:17:37 +0200,
Cássio Gabriel wrote:
>
> snd_akm4xxx_init() clears the register and volume caches before
> dispatching by codec type. The AK5365 case then returns immediately,
> leaving the software cache at zero instead of the documented AK5365
> reset defaults.
>
> The AK5365 capture volume controls read from volumes[] and the proc
> register dump reads from images[], so the initial capture volume state
> and proc output are wrong until a control write happens.
>
> Seed the AK5365 cache with its documented reset defaults instead of
> adding a guessed init sequence. The datasheet documents the reset
> values and states that MCLK/LRCK changes do not require a PDN/PWN
> reset because the chip has a built-in reset-free circuit.
>
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-04-09 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 15:17 [PATCH] ALSA: i2c: ak4xxx-adda: seed AK5365 cache with reset defaults Cássio Gabriel
2026-04-09 10:01 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4vcjvut.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox