From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame
Date: Thu, 05 Feb 2026 09:51:56 +0100 [thread overview]
Message-ID: <87a4xnfu8j.fsf@bootlin.com> (raw)
In-Reply-To: <aYO2IPsoxmDtTsec@smile.fi.intel.com> (Andy Shevchenko's message of "Wed, 4 Feb 2026 23:12:00 +0200")
Hi Andy,
On 04/02/2026 at 23:12:00 +02, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Wed, Feb 04, 2026 at 02:25:27AM +0100, Andy Shevchenko wrote:
>> Compiler is not happy about used stack frame:
>>
>> drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer':
>> drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
>>
>> Fix this by factoring out do_write_buffer_locked().
>
> My gosh, I already sent a v2 earlier and there were some replies,
> I need to check...
I'm not sure I get what you mean here? I got no reply (in my inbox) to
your v2. I am letting a bit of time for Vignesh to take a look, but I
know he's busy so I might take it nevertheless by the end of the week as
we are approaching the merge window.
Cheers,
Miquèl
next prev parent reply other threads:[~2026-02-05 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 1:25 [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame Andy Shevchenko
2026-02-04 21:12 ` Andy Shevchenko
2026-02-05 8:51 ` Miquel Raynal [this message]
2026-02-05 15:57 ` Andy Shevchenko
2026-02-05 17:34 ` Miquel Raynal
2026-02-06 5:56 ` Vignesh Raghavendra
2026-02-06 7:44 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2026-01-24 13:35 Andy Shevchenko
2026-01-24 22:41 ` kernel test robot
2026-02-10 10:05 ` Vignesh Raghavendra
2026-02-10 14:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4xnfu8j.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox