From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCC05356A2C for ; Thu, 5 Feb 2026 08:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770281522; cv=none; b=e3Pt30NFIgyjlQWHNnZHl8GxGatltvhnQfEIAKSqGBVPK25/OLAnrxs7TkWHF/3t6BoGcip1KsRxABOE9RgWaufXH/qewOeWi0iiIJhvqmH7jhxovN0mJvYcpCxDtY0/NQ7e4ItyrPnGivN8KUUDyXLzOgmwx3fnyuQ/I5LkhMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770281522; c=relaxed/simple; bh=uegmMgwK6YxerG6iMFSVVMyjG09NzjU6hD8x2MGcP7w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=t1FRnB8IcLYhYPJxWGSG+72aDAbte5d9xXg2utJlVWIeEHEjD1zflmIR4Wy0/MseneKP+RKlJ0XoYcbED+nvBSrfwdjzGp9YACrGJirB4K0Ac6n4aIJU/SFdPgJs3+nNFaFkhGNz60Dq2CU/Q7gFWA0kb7g3aXAc9a8+bps2Nxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=fjWTtUrS; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="fjWTtUrS" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 744AC1A2C14; Thu, 5 Feb 2026 08:52:00 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4AE2F606FD; Thu, 5 Feb 2026 08:52:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E4366119A865B; Thu, 5 Feb 2026 09:51:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770281519; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=uegmMgwK6YxerG6iMFSVVMyjG09NzjU6hD8x2MGcP7w=; b=fjWTtUrSyRnUs3sMYgrTiKRy6kukwlzpe4KTICNekoXSWHGHGfc9kYoiQOzyFnEs4oeY9u IxKF/3/BER9uQzZXVYShDdS2qOjTvJaekc2kklbSP4v3Q98TNSz/aUiN94oPTejS+Zs+WV SA/RU0wyyD5nals6ZPHYXr0RqU1Dj3AQ0el5zOUJ1TGRzNE05tv6VQulsL6VOYGcJB/Rp9 DeChfDxb4jJem5YiVrx1iTA8ZoqLUkbmfa0/TqnODJYfDZMDMh7cw3fHvzIgasTpok4CGU CQcYctMLwi47gUTvz9Zomtg2p8Iu2nrhHO9q4Fnk/eH+Cjv96K00ldekDCXfrQ== From: Miquel Raynal To: Andy Shevchenko Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Richard Weinberger , Vignesh Raghavendra Subject: Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame In-Reply-To: (Andy Shevchenko's message of "Wed, 4 Feb 2026 23:12:00 +0200") References: <20260204012630.2211832-1-andriy.shevchenko@linux.intel.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Thu, 05 Feb 2026 09:51:56 +0100 Message-ID: <87a4xnfu8j.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Andy, On 04/02/2026 at 23:12:00 +02, Andy Shevchenko wrote: > On Wed, Feb 04, 2026 at 02:25:27AM +0100, Andy Shevchenko wrote: >> Compiler is not happy about used stack frame: >>=20 >> drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer': >> drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 129= 6 bytes is larger than 1280 bytes [-Werror=3Dframe-larger-than=3D] >>=20 >> Fix this by factoring out do_write_buffer_locked(). > > My gosh, I already sent a v2 earlier and there were some replies, > I need to check... I'm not sure I get what you mean here? I got no reply (in my inbox) to your v2. I am letting a bit of time for Vignesh to take a look, but I know he's busy so I might take it nevertheless by the end of the week as we are approaching the merge window. Cheers, Miqu=C3=A8l