From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: "Mark Brown" <broonie@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Vaishnav Achath" <vaishnav.a@ti.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Hervé Codina" <herve.codina@bootlin.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Santhosh Kumar K" <s-k6@ti.com>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 01/17] spi: dt-bindings: cdns,qspi-nor: Remove duplicated constraints
Date: Thu, 22 Jan 2026 15:21:04 +0100 [thread overview]
Message-ID: <87a4y5pw33.fsf@bootlin.com> (raw)
In-Reply-To: <20260121221400.GA218496-robh@kernel.org> (Rob Herring's message of "Wed, 21 Jan 2026 16:14:00 -0600")
On 21/01/2026 at 16:14:00 -06, Rob Herring <robh@kernel.org> wrote:
> On Wed, Jan 21, 2026 at 06:04:57PM +0100, Miquel Raynal (Schneider Electric) wrote:
>> The if/then/else block sets the restrictions in all cases for
>> resets/reset-names, very much like it does for other properties as well
>> such as cdns,fifo-depth. Drop the constraints from the place where these
>> constraints are simply ignored.
>
> But they aren't.
I looked deeper. Indeed the two constraints are applied, and it works
because the constraints in "if" blocks must be subsets of what is
already a constraint in the main body.
...
>> - resets:
>> - minItems: 2
>> - maxItems: 3
>> -
>> - reset-names:
>> - minItems: 2
>> - maxItems: 3
>> - items:
>> - enum: [ qspi, qspi-ocp, rstc_ref ]
>
> The primary reason to keep this is to prevent making up other names. If
> the names are only in if/then schemas then anything is allowed and it's
> not visible in reviews.
Makes sense. I will drop this patch.
Thanks,
Miquèl
next prev parent reply other threads:[~2026-01-22 14:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 17:04 [PATCH v3 00/17] spi: cadence-qspi: Add Renesas RZ/N1 support Miquel Raynal (Schneider Electric)
2026-01-21 17:04 ` [PATCH v3 01/17] spi: dt-bindings: cdns,qspi-nor: Remove duplicated constraints Miquel Raynal (Schneider Electric)
2026-01-21 22:14 ` Rob Herring
2026-01-22 14:21 ` Miquel Raynal [this message]
2026-01-21 17:04 ` [PATCH v3 02/17] spi: dt-bindings: cdns,qspi-nor: Drop label in example Miquel Raynal (Schneider Electric)
2026-01-21 22:14 ` Rob Herring (Arm)
2026-01-21 17:04 ` [PATCH v3 03/17] spi: dt-bindings: cdns,qspi-nor: Add examples for testing the specific cases Miquel Raynal (Schneider Electric)
2026-01-21 23:07 ` Rob Herring
2026-01-22 14:35 ` Miquel Raynal
2026-01-22 15:32 ` Rob Herring
2026-01-21 17:05 ` [PATCH v3 04/17] spi: dt-bindings: cdns,qspi-nor: Add Renesas RZ/N1D400 to the list Miquel Raynal (Schneider Electric)
2026-01-21 23:09 ` Rob Herring (Arm)
2026-01-21 17:05 ` [PATCH v3 05/17] spi: cadence-qspi: Align definitions Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 06/17] spi: cadence-qspi: Fix style and improve readability Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 07/17] spi: cadence-qspi: Fix ORing style and alignments Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 08/17] spi: cadence-qspi: Remove an useless operation Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 09/17] spi: cadence-qspi: Make sure we filter out unsupported ops Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 10/17] spi: cadence-qspi: Fix probe error path and remove Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 11/17] spi: cadence-qspi: Try hard to disable the clocks Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 12/17] spi: cadence-qspi: Kill cqspi_jh7110_clk_init Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 13/17] spi: cadence-qspi: Add a flag for controllers without indirect access support Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 14/17] spi: cadence-qspi: Make sure write protection is disabled Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 15/17] spi: cadence-qspi: Use a default value for cdns,fifo-width Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 16/17] spi: cadence-qspi: Add support for the Renesas RZ/N1 controller Miquel Raynal (Schneider Electric)
2026-01-21 17:05 ` [PATCH v3 17/17] ARM: dts: r9a06g032: Describe the QSPI controller Miquel Raynal (Schneider Electric)
2026-01-22 10:59 ` Geert Uytterhoeven
2026-01-22 13:12 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4y5pw33.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=herve.codina@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=pascal.eberhard@se.com \
--cc=pratyush@kernel.org \
--cc=robh@kernel.org \
--cc=s-k6@ti.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox