From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3DA9344024; Thu, 22 Jan 2026 14:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769091673; cv=none; b=q7MsGVghZkoLtgFQ+3YQMs2SQ69l3vhEfuZcHmTKEpoSO954uSxfeXswFdGCjiTQCLAUk6UXbzVNebTZmqp5A0yrlWDWyqDij3P2OBS2P9oKI4XC35B8F6aJeX21P2px/AYqVCbjLxgSx+UA9Cgjvs8TpvyMEHBH2YWlEupb0iU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769091673; c=relaxed/simple; bh=F+5aNniE9B3U4nh1z1zfWzIiTm1JAwc6qCs+DV9yMEo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=tmFDEOgFoJFNI7t55QehFQlmRBunhNb4j+4DaU8fxYhn4U5zFC9/zrwXbTubQTEqtUf5kJKj6CZEFIAsNIMnOT3oCD/p5iSJfHgFV5HOJaIFsa5mkDF2KYLRXZgtDq+AQVX8WER1SccTsWAQ+6keMlEspMBTIJpRmG7Ige/jBsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=N4+eDW3E; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="N4+eDW3E" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 34B811A2A91; Thu, 22 Jan 2026 14:21:10 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 00A86606B6; Thu, 22 Jan 2026 14:21:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 95040119B81B3; Thu, 22 Jan 2026 15:21:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769091669; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=TsNML+3xOwrc4+PpSLQW2hjh0yxYNzlX5rpJRRrE/NU=; b=N4+eDW3E48c+twnL6eSo5849Eho0y6eB9EAEbXs2hSaEYg7OHh+jtUki6YGSBYpHNsLvmy U39Dl7CQFBPebANR5xLQhMZcjgK/S1tC8zY8/3IiruKeklqcrbyYu8JwaXWQXxzz9x65Rs t+dbwbeNPhhHIX8qqcGVnfwfIIg93kRqnoivzBboja/HrqvBmn/Kw5CWXETzDafOhVsp2s Jx9ml11sewsgF9jpsjOj/gOgrfez5ydlg3O9z45TnTfQLT8ey4YYCBOgalPT9feDcLc0uK 24Qlv9GwbqKOFU0wgZ+MYtdirkoO2aVidsvqB8JOKWMCrTm1MTmXiSZa5jp7SA== From: Miquel Raynal To: Rob Herring Cc: Mark Brown , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Vaishnav Achath , Thomas Petazzoni , =?utf-8?Q?Herv=C3=A9?= Codina , Wolfram Sang , Vignesh Raghavendra , Santhosh Kumar K , Pratyush Yadav , Pascal Eberhard , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 01/17] spi: dt-bindings: cdns,qspi-nor: Remove duplicated constraints In-Reply-To: <20260121221400.GA218496-robh@kernel.org> (Rob Herring's message of "Wed, 21 Jan 2026 16:14:00 -0600") References: <20260121-schneider-6-19-rc1-qspi-v3-0-43e70fab4444@bootlin.com> <20260121-schneider-6-19-rc1-qspi-v3-1-43e70fab4444@bootlin.com> <20260121221400.GA218496-robh@kernel.org> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Thu, 22 Jan 2026 15:21:04 +0100 Message-ID: <87a4y5pw33.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 21/01/2026 at 16:14:00 -06, Rob Herring wrote: > On Wed, Jan 21, 2026 at 06:04:57PM +0100, Miquel Raynal (Schneider Electr= ic) wrote: >> The if/then/else block sets the restrictions in all cases for >> resets/reset-names, very much like it does for other properties as well >> such as cdns,fifo-depth. Drop the constraints from the place where these >> constraints are simply ignored. > > But they aren't. I looked deeper. Indeed the two constraints are applied, and it works because the constraints in "if" blocks must be subsets of what is already a constraint in the main body. ... >> - resets: >> - minItems: 2 >> - maxItems: 3 >> - >> - reset-names: >> - minItems: 2 >> - maxItems: 3 >> - items: >> - enum: [ qspi, qspi-ocp, rstc_ref ] > > The primary reason to keep this is to prevent making up other names. If=20 > the names are only in if/then schemas then anything is allowed and it's=20 > not visible in reviews. Makes sense. I will drop this patch. Thanks, Miqu=C3=A8l