From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE5C93446B7 for ; Wed, 17 Dec 2025 15:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765986494; cv=none; b=u7jmzg9PcnH/d2PWf+O4jRTHdq0649xskvw6Deh/oSeAb11qJravmzCfEzmxNL7yDLf7+yeIFLk/tcy/Ch2/IaEiflOppdCEDKyfu9l+BRwwyaKjKolKnqeIdS80zyfQ3MZzhWesfS7YNjFZ7VzPU9x0CQRMYjjOYyH9s2l3LEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765986494; c=relaxed/simple; bh=PQaplJm3gICXcJ/D8khV8sK9h8Jhdr/PjOyZobO7ek0=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References: MIME-Version:Content-Type; b=UsudHtjmQq6rBzMJy6tVPdJ7ZGiTLWF3+EqMuznCx9AeADBV6FlFRygjqmp2Kq091+sN6fkO4I8uXkUetvj5x2+QSXRMeSacTlMKZMQNQB6ghao6ODNGT7jcF4lhZLcIEPSs7hOicUPUsKGhm800o8QWP2cb38PAEmjuS94G9Ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aEv5Ge+e; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aEv5Ge+e" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a09757004cso52513545ad.3 for ; Wed, 17 Dec 2025 07:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765986492; x=1766591292; darn=vger.kernel.org; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=k7g6szJSc9qKXraE1vzVnFUR39QDkw3X32snO8YJ7Qo=; b=aEv5Ge+edH7Gdee0INBqDnyxmkskUh9ROnT0cLsrfnTQyTCl1ZMF2hSGlt6PSUkRvg yjsFCzUAhYR/cLU4oG7u22mOJBWrqKKQDwCF4Q9hvoOsYtw+IyjRbwzG77llrG6FMylF z/C5J97K72XgeIDT/UFc+S1E0JtDFpROIfRHR3VQlsFiNziPfjFe+WfZKsCtDu3UIRRf saW1ynJGZVVycjHNqh8miz7vRupvZ3+Di3NIlunNXr/qug29l+fX4U4kUrYWBimraPqD +S9cKbVZLvz1Az/xHR9ciusZSKPoB+AlOAvcnZF6seh94tp+8h6nug6/5f3DVgZEVZdX YzjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765986492; x=1766591292; h=mime-version:references:message-id:date:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k7g6szJSc9qKXraE1vzVnFUR39QDkw3X32snO8YJ7Qo=; b=chnVUzurJHZONTn8onUgJ2JlxnFx1GgupjLMumCX1BoRYBa6QZ1Xj/lJZW8tyEy9n4 9p3AYSQg+kboRq42KYhqlYDLEOc6YF5oJZC9qX01uQ1srGnXm+KXnkX3+7MmJ/uFulKT N3OHaSPfJhc0TsXO3VbQehC4N1wQzwhm5gHyuCzxortS70/a2G39hX+S4NtE6ALPH3vb udmNDMktdIkv7S6o74+xQLaChmNZhsIxiKi9i76LTm+IsbAwsGB+VoxgUcZQFgb2r1f5 aoUcS7a0bf6+Wb96E1IGVzsYvHtKQ79f2DVyMG3dra34vAhESzDFW2ewCKNGk568LUbY Y5MQ== X-Forwarded-Encrypted: i=1; AJvYcCVY9Bz6cfYHSz/nqMCsymCdNjFGh+IzQlPuQrP3wfxZa0eyaaeNdDAGyxYzL3SiexcZAQtZwtuBs3r1jA4=@vger.kernel.org X-Gm-Message-State: AOJu0YxwqEti9AlTE1qhIzEScXkVANNS6cGX781LTHy9LzUAAj3iGu6z zKTRWIoLpEFlm0C7M9GeTmKjQPt4jjHz1NYymeAGnHZ1Pf12Kkf1ZCba X-Gm-Gg: AY/fxX7roperErSF7DsVpv7Ba05YY8yFt+WZMlaFZE78RTJZKyBa8JpfgdfaqL7XEE4 DnzhNQCmW4KI+Hn5CkFwcOxNGyHSvAP5aJbE8UrdmFpxWnwbueimY9MxCsRPOsVSBi2rraeZ4Yi k3kwHg5KTdpub9CvXZPwPMvbMM3s4LSeGPt/20cFaS02WnTcO2beFX4+G4vThgvc83CSvfEThqy lCkQTmkl7rH+GcpZG0K9B1Xeh9Y9mmjHRloj5qlu7osrgI0cWO/wYGZBzCfbsbEhm9342dIlJ30 2sL7elcUUQdexGUBWPU1BU0LTxp6vfG5orbm3zVFjPAodZGoBiOFlskZYeR/+fytTixVEtj3BI7 ch4M3XhvCDrPSaMgKphfKLpq5q/1zMUj4WOPXAciDa9CMinbTzBHtphjcIIbVsdVo6mwhZKLsZH aRdy2a7gx21E2di41O X-Google-Smtp-Source: AGHT+IGzrC8xHoSohluxl3TB8gicGFdkGjx48ZJyAE+fsjdi1rZJJgtl3YetY/wOPW+z2c4mkNcmfA== X-Received: by 2002:a17:902:cf03:b0:2a0:bb05:df4f with SMTP id d9443c01a7336-2a0bb05e314mr123346515ad.44.1765986491997; Wed, 17 Dec 2025 07:48:11 -0800 (PST) Received: from dw-tp ([171.76.225.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29eea016ef4sm207003795ad.56.2025.12.17.07.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 07:48:11 -0800 (PST) From: Ritesh Harjani (IBM) To: Ryan Roberts , Kevin Brodsky , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Anshuman Khandual , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , David Hildenbrand , "David S. Miller" , David Woodhouse , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Suren Baghdasaryan , Thomas Gleixner , Venkat Rao Bagalkote , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Subject: Re: [PATCH v6 14/14] mm: Add basic tests for lazy_mmu In-Reply-To: Date: Wed, 17 Dec 2025 21:16:14 +0530 Message-ID: <87a4zhkt6h.ritesh.list@gmail.com> References: <20251215150323.2218608-1-kevin.brodsky@arm.com> <20251215150323.2218608-15-kevin.brodsky@arm.com> <20251216201403.4647a4f9861d3122ee9e90d7@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Ryan Roberts writes: > On 17/12/2025 09:26, Kevin Brodsky wrote: >> On 17/12/2025 05:14, Andrew Morton wrote: >>> On Mon, 15 Dec 2025 15:03:23 +0000 Kevin Brodsky wrote: >>> >>>> Add basic KUnit tests for the generic aspects of the lazy MMU mode: >>>> ensure that it appears active when it should, depending on how >>>> enable/disable and pause/resume pairs are nested. >>> I needed this for powerpc allmodconfig; >>> >>> --- a/arch/powerpc/mm/book3s64/hash_tlb.c~mm-add-basic-tests-for-lazy_mmu-fix >>> +++ a/arch/powerpc/mm/book3s64/hash_tlb.c >>> @@ -30,6 +30,7 @@ >>> #include >>> >>> DEFINE_PER_CPU(struct ppc64_tlb_batch, ppc64_tlb_batch); >>> +EXPORT_SYMBOL_GPL(ppc64_tlb_batch); >>> >>> /* >>> * A linux PTE was changed and the corresponding hash table entry >>> @@ -154,6 +155,7 @@ void __flush_tlb_pending(struct ppc64_tl >>> flush_hash_range(i, local); >>> batch->index = 0; >>> } >>> +EXPORT_SYMBOL_GPL(__flush_tlb_pending); >>> >>> void hash__tlb_flush(struct mmu_gather *tlb) >>> { >>> _ >> >> Oh indeed I hadn't considered that arch_{enter,leave}_lazy_mmu_mode() >> refer to those symbols on powerpc... Maybe a bit overkill to export >> those just for a test module, but I'm not sure there's a good >> alternative. Forcing LAZY_MMU_MODE_KUNIT_TEST=y is ugly as it would also >> force KUNIT=y. Alternatively we could depend on !PPC, not pretty either. > > Does EXPORT_SYMBOL_IF_KUNIT() help? > yes, that make sense. Thanks for the suggestion! I guess we will need a diff like this in that case - diff --git a/arch/powerpc/mm/book3s64/hash_tlb.c b/arch/powerpc/mm/book3s64/hash_tlb.c index fbdeb8981ae7..ec2941cec815 100644 --- a/arch/powerpc/mm/book3s64/hash_tlb.c +++ b/arch/powerpc/mm/book3s64/hash_tlb.c @@ -25,11 +25,12 @@ #include #include #include - +#include #include DEFINE_PER_CPU(struct ppc64_tlb_batch, ppc64_tlb_batch); +EXPORT_SYMBOL_IF_KUNIT(ppc64_tlb_batch); /* * A linux PTE was changed and the corresponding hash table entry @@ -154,6 +155,7 @@ void __flush_tlb_pending(struct ppc64_tlb_batch *batch) flush_hash_range(i, local); batch->index = 0; } +EXPORT_SYMBOL_IF_KUNIT(__flush_tlb_pending); void hash__tlb_flush(struct mmu_gather *tlb) { diff --git a/mm/tests/lazy_mmu_mode_kunit.c b/mm/tests/lazy_mmu_mode_kunit.c index 2720eb995714..340d7cda9096 100644 --- a/mm/tests/lazy_mmu_mode_kunit.c +++ b/mm/tests/lazy_mmu_mode_kunit.c @@ -69,3 +69,4 @@ kunit_test_suite(lazy_mmu_mode_test_suite); MODULE_DESCRIPTION("Tests for the lazy MMU mode"); MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING"); -ritesh