Re: [PATCH RFC 01/13] PCI: Add SNIA SDXI accelerator sub-class

Nathan Lynch
2025-09-15T20:17:32Z

Bjorn Helgaas <helgaas@kernel.org> writes:
> On Fri, Sep 05, 2025 at 01:48:24PM -0500, Nathan Lynch via B4 Relay wrote:
>> From: Nathan Lynch <nathan.lynch@amd.com>
>>
>> This was added to the PCI Code and ID Assignment Specification in
>> revision 1.14 (2021). Refer to 1.19. "Base Class 12h" of that document
>> as well as the "SDXI PCI-Express Device Architecture" chapter of the
>> SDXI specification:
>
> Would prefer if this said:
>
> Add sub-class code for SNIA Smart Data Accelerator Interface (SDXI).
> See PCI Code and ID Assignment spec r1.14, sec 1.19.
>
> so the antecedent of "this" is here instead of in the subject and
> "1.19" doesn't get confused with a spec revision.
>
>> """
>> SDXI functions are expected to be identified through the SDXI class
>> code.
>> * SNIA Smart Data Accelerator Interface (SDXI) controller:
>> * Base Class = 0x12
>> * Sub Class = 0x01
>> * Programming Interface = 0x0
>> """
>>
>> Information about SDXI may be found at the SNIA website:
>>
>> https://www.snia.org/sdxi
>
> I don't think the SDXI spec material is really necessary. The PCI
> Code and ID spec is definitive for class codes.
>
>> Co-developed-by: Wei Huang <wei.huang2@amd.com>
>> Signed-off-by: Wei Huang <wei.huang2@amd.com>
>> Signed-off-by: Nathan Lynch <nathan.lynch@amd.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Thanks Bjorn, I have made the commit message changes you've suggested
and incorporated your ack for this patch.