From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F19A717E900 for ; Wed, 8 Jan 2025 16:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736352350; cv=none; b=guXhrSB+8Q9vl5I94dYKF6h5tqZTf+JDqkk5r1eD6HSDBqMfPdobqCfXAEaK6aGDnQNYpX1pemu41K0p5BMumHHSKb82iqQY6eDJJttJUiiyP6eog/qZxhqgFezB2dvdFCo7tVnGL6rR5TGqcp85vg7VViZEdw4oR1Yo9rHljic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736352350; c=relaxed/simple; bh=RPVjfAPiQZWjs3rho+O+P+ESNZdhVryyRpQKlmsV+bk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=BhT8rhmKxVKj4RxDHMGOyElgVOwJcWDq9VA5l+eh9beDLvPxptuf3OAG2GaLkFKBRIAv+GWt6IEnc9qPof9FpS4ygz+ln/Jz9y/6rr5//SsKYbJXHyPR7i97bdXDn+y/YugLElafMKt6MVKRe+kYIQVnb1CedStP9ToLpKWqOh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=d72OOZjO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d72OOZjO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736352347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aooob8p6GkS7voK1h38Ntic+p2XSpsx17M7hrSg96Ls=; b=d72OOZjOie5fVkZ89kIDItZMGsMUJpeP3RBe6cp1it3yciBJXp43wqxUqfT6zxxy7LJ2pF NSzJv9cO8YAneshpTcBuqYJowtYzlVFV0L8dvQf94dvA8JG0bUhBY6j6n4UkK/CMpXhYq6 OVdYVkFACMLaMZN1Pe37SHYo2E41Btw= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-r48NkSm6NSm7GXqdU21dZw-1; Wed, 08 Jan 2025 11:05:45 -0500 X-MC-Unique: r48NkSm6NSm7GXqdU21dZw-1 X-Mimecast-MFC-AGG-ID: r48NkSm6NSm7GXqdU21dZw Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-467b5861766so343283641cf.2 for ; Wed, 08 Jan 2025 08:05:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736352345; x=1736957145; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aooob8p6GkS7voK1h38Ntic+p2XSpsx17M7hrSg96Ls=; b=B7KhOpo1yPsLFWFsVFmxHxk67MOXWXC1JZ5Mf96iznQKiRrKr7tutzxwr3k4Jy8h+j qWq/Pkn8HxhrZ+S3gW8967MBtX0Mv9Xf6wfAtFWlatEYRU62Tv7fQBt+CAMOv3rX4Wwn 49nWoCzlCNCYQmsVF69aSI4G0GjmPdm+Y40Nfv+IYMI2tTaG6nm/9YUg1CMUBn/ub4fj CPtEE3nb/DlrTziXpwCP5aHMiSZ24bfOVe7tBR54tqHLjOX4gUiW3ScrtUANZ/XNq8Oz wf039f2z4tSpEl3rBj8n+f0WI4hYl+inEtRE0kS+XshqT0IPL0zrEEJU2zRt7/qSs02t rTWw== X-Forwarded-Encrypted: i=1; AJvYcCV+kKpr+Nk8OBQvRX1k/+JIcZSAI1uoHgvg/ymp0KH7uvuGI0a48UoEvsWNFP1J160ow4L1oB1YwbMvVTM=@vger.kernel.org X-Gm-Message-State: AOJu0YwlVDiQ9MQG3NAMv38+eFOveeF7oUE5WlxhZox+KzWRUgwpRPXD Q+UG2N9zB4L5OcKMsTmbQ4DStz7X/VxM/SGkzaNhWAzXzNQvwfLXwhmLwTv0kZXZrmPYbmEUS6k rv+pwu19LsrdPL2rCjNZmng0VkD5JY6SImmtEksfixc1apNilPwCad1p4zpPX6hy/WZ9vZ8EqCD oqcYHgVEWw/Ay2aJK+mTcTH8gUJSgW6+hYCZII3m92id+9jQ== X-Gm-Gg: ASbGncsatAQLep3CSAYQsn9Qhp0UzEIG6+dm4Y0Xg2r6ULdSzzF82Ya/ZIIsQja2rF0 D04ST0VGKsO4syGf1LRj3tECcUx2ixcCnnFCdG/Y1lILjbV4HFsx/lSfbqlqrxBsVK3nX/qBkcy 1l4JwUt5N/d2vk382oLha1fbPWBbxg6PmplGEsMVglLJolfrT4FobXrsHpqyuPdfJtv27+Thpv9 AHKHGEDKN1cDQh3nuw8W18DI7SXducFIJHt1nyo88J51IXFI74= X-Received: by 2002:ac8:5ac5:0:b0:467:6692:c18b with SMTP id d75a77b69052e-46c70fd4871mr51790441cf.5.1736352345242; Wed, 08 Jan 2025 08:05:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/nWL93kgVzOvKkuMSf7q/VWr8jqCZajAeSnzGnvOkEitk/Rlfvn2gmF0ZdQFr3liWLMlsMw== X-Received: by 2002:ac8:5ac5:0:b0:467:6692:c18b with SMTP id d75a77b69052e-46c70fd4871mr51789871cf.5.1736352344687; Wed, 08 Jan 2025 08:05:44 -0800 (PST) Received: from fedora (g2.ign.cz. [91.219.240.8]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46b2b534419sm40916541cf.67.2025.01.08.08.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 08:05:44 -0800 (PST) From: Vitaly Kuznetsov To: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Cc: x86@kernel.org, "H. Peter Anvin" , Nikolay Borisov , Michael Petlan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/entry: Add __init to ia32_emulation_override_cmdline() In-Reply-To: <20241210151650.1746022-1-vkuznets@redhat.com> References: <20241210151650.1746022-1-vkuznets@redhat.com> Date: Wed, 08 Jan 2025 17:05:40 +0100 Message-ID: <87a5c1b8a3.fsf@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Vitaly Kuznetsov writes: > ia32_emulation_override_cmdline() is an early_param() arg and these > are only needed at boot time. In fact, all other early_param() functions > in arch/x86 seem to have '__init' annotation and > ia32_emulation_override_cmdline() is the only exception. > > Fixes: a11e097504ac ("x86: Make IA32_EMULATION boot time configurable") > Signed-off-by: Vitaly Kuznetsov > --- > arch/x86/entry/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c > index 94941c5a10ac..51efd2da4d7f 100644 > --- a/arch/x86/entry/common.c > +++ b/arch/x86/entry/common.c > @@ -142,7 +142,7 @@ static __always_inline int syscall_32_enter(struct pt_regs *regs) > #ifdef CONFIG_IA32_EMULATION > bool __ia32_enabled __ro_after_init = !IS_ENABLED(CONFIG_IA32_EMULATION_DEFAULT_DISABLED); > > -static int ia32_emulation_override_cmdline(char *arg) > +static int __init ia32_emulation_override_cmdline(char *arg) > { > return kstrtobool(arg, &__ia32_enabled); > } Post-holidays ping) -- Vitaly