From: Takashi Iwai <tiwai@suse.de>
To: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: vkoul@kernel.org, perex@perex.cz, tiwai@suse.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
broonie@kernel.org, amadeuszx.slawinski@linux.intel.com
Subject: Re: [PATCH] ALSA: compress_offload: Use runtime pointer in snd_compr_poll()
Date: Wed, 06 Nov 2024 09:46:09 +0100 [thread overview]
Message-ID: <87a5ecwy0e.wl-tiwai@suse.de> (raw)
In-Reply-To: <20241106075312.15601-1-peter.ujfalusi@linux.intel.com>
On Wed, 06 Nov 2024 08:53:12 +0100,
Peter Ujfalusi wrote:
>
> runtime is not used as seen with W=1 :
> sound/core/compress_offload.c: In function ‘snd_compr_poll’:
> sound/core/compress_offload.c:409:35: error: variable ‘runtime’ set but not used [-Werror=unused-but-set-variable]
> 409 | struct snd_compr_runtime *runtime;
> | ^~~~~~~
>
> Instead of dropping the runtime, use it in the function in place of
> stream->runtime
>
> Fixes: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2024-11-06 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 7:53 [PATCH] ALSA: compress_offload: Use runtime pointer in snd_compr_poll() Peter Ujfalusi
2024-11-06 8:19 ` Jaroslav Kysela
2024-11-06 8:46 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ecwy0e.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox