From: Thomas Gleixner <tglx@linutronix.de>
To: Yuntao Wang <yuntao.wang@linux.dev>,
linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Thorsten Blum <thorsten.blum@toblux.com>,
Tony Luck <tony.luck@intel.com>,
Daniel Sneddon <daniel.sneddon@linux.intel.com>,
Yuntao Wang <yuntao.wang@linux.dev>
Subject: Re: [PATCH] x86/apic: Fix the issues in x2apic_disable()
Date: Mon, 12 Aug 2024 16:48:05 +0200 [thread overview]
Message-ID: <87a5hhsspm.ffs@tglx> (raw)
In-Reply-To: <20240812100819.870513-1-yuntao.wang@linux.dev>
On Mon, Aug 12 2024 at 18:08, Yuntao Wang wrote:
> static __init void x2apic_disable(void)
> {
> - u32 x2apic_id, state = x2apic_state;
> + u32 x2apic_id;
>
> - x2apic_mode = 0;
> - x2apic_state = X2APIC_DISABLED;
> -
> - if (state != X2APIC_ON)
> - return;
> + if (x2apic_state < X2APIC_ON)
> + goto out;
There is no point in overwriting the state in case it is < ON, no?
Thanks,
tglx
next prev parent reply other threads:[~2024-08-12 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 10:08 [PATCH] x86/apic: Fix the issues in x2apic_disable() Yuntao Wang
2024-08-12 14:48 ` Thomas Gleixner [this message]
2024-08-12 15:53 ` Yuntao Wang
2024-08-12 18:00 ` Thomas Gleixner
2024-08-13 1:48 ` [PATCH v2] " Yuntao Wang
2024-08-13 13:21 ` [tip: x86/urgent] x86/apic: Make x2apic_disable() work correctly tip-bot2 for Yuntao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5hhsspm.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=thorsten.blum@toblux.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yuntao.wang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox