public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Stefan Binding <sbinding@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH v1 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands
Date: Fri, 22 Sep 2023 16:35:45 +0200	[thread overview]
Message-ID: <87a5tecm2m.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230922142818.2021103-1-sbinding@opensource.cirrus.com>

On Fri, 22 Sep 2023 16:28:16 +0200,
Stefan Binding wrote:
> 
> Some systems use older firmware which does not support newer commands
> which are used to enable external boost. For those systems, we can
> workaround this by writing the registers directly.
> 
> We can use the firmware version, stored inside cs_dsp, to determine
> whether or not the command is supported.
> To achieve this, it requires a cleanup in the api, to pass the cs_dsp
> struct into the function.
> 
> We can also remove the redundant boolean firmware_running from the HDA
> driver, and use the equivalent state inside cs_dsp.

So those are fixes needed for 6.6 kernel?  Or they are something new?

> This chain is based on Mark's branch, since the api change was made to
> the function in sound/soc/codecs/cs35l41-lib.c.

I'd need a PR from Mark before applying those, then.


thanks,

Takashi

  parent reply	other threads:[~2023-09-22 14:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 14:28 [PATCH v1 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands Stefan Binding
2023-09-22 14:28 ` [PATCH v1 1/2] ALSA: hda: cs35l41: Remove unnecessary boolean state variable firmware_running Stefan Binding
2023-09-22 14:28 ` [PATCH v1 2/2] ALSA: cs35l41: Fix for old systems which do not support command Stefan Binding
2023-09-22 14:30   ` Mark Brown
2023-09-22 14:35 ` Takashi Iwai [this message]
2023-09-22 14:38   ` [PATCH v1 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands Mark Brown
2023-09-22 14:42     ` Takashi Iwai
2023-09-22 14:44   ` Stefan Binding
2023-09-22 14:48     ` Mark Brown
2023-09-22 14:53       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5tecm2m.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox