From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A11E6FE3C for ; Fri, 22 Sep 2023 14:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbjIVOfz (ORCPT ); Fri, 22 Sep 2023 10:35:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbjIVOfw (ORCPT ); Fri, 22 Sep 2023 10:35:52 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E1F0C6 for ; Fri, 22 Sep 2023 07:35:47 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BAEA11FEF7; Fri, 22 Sep 2023 14:35:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695393345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+e8d8EPK3+d0DLp3Ownkw5Gy/YEy3/TX5WBpNFkkHhs=; b=k2bw/NDzRNlzjlXfoDwV3zQ+0HxJ1u6oYae0ynND2XpbnAgC+RKpNCKmqwp2fwx5VUA0vD +ft3uiwAY93ePcAqMe85VNN+fAzZpYat2tG95K/f1RuqpPo6FB9EE+eefBgAiHUSRbKaJF FreAckPgto5+pZd0FZvmdxWpuw08lSU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695393345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+e8d8EPK3+d0DLp3Ownkw5Gy/YEy3/TX5WBpNFkkHhs=; b=3keSnqGF2eopnJ9IzKCWAO7qhD15ckTn/p1j3CKnAWbaWWeTAN7K3+AeLHkn6yPhLaqfy4 U84SiBiWWAl/fEAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8DD1913478; Fri, 22 Sep 2023 14:35:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /v2GIUGmDWXlAgAAMHmgww (envelope-from ); Fri, 22 Sep 2023 14:35:45 +0000 Date: Fri, 22 Sep 2023 16:35:45 +0200 Message-ID: <87a5tecm2m.wl-tiwai@suse.de> From: Takashi Iwai To: Stefan Binding Cc: Mark Brown , Jaroslav Kysela , "Takashi Iwai" , , , Subject: Re: [PATCH v1 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands In-Reply-To: <20230922142818.2021103-1-sbinding@opensource.cirrus.com> References: <20230922142818.2021103-1-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Sep 2023 16:28:16 +0200, Stefan Binding wrote: > > Some systems use older firmware which does not support newer commands > which are used to enable external boost. For those systems, we can > workaround this by writing the registers directly. > > We can use the firmware version, stored inside cs_dsp, to determine > whether or not the command is supported. > To achieve this, it requires a cleanup in the api, to pass the cs_dsp > struct into the function. > > We can also remove the redundant boolean firmware_running from the HDA > driver, and use the equivalent state inside cs_dsp. So those are fixes needed for 6.6 kernel? Or they are something new? > This chain is based on Mark's branch, since the api change was made to > the function in sound/soc/codecs/cs35l41-lib.c. I'd need a PR from Mark before applying those, then. thanks, Takashi