From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA747C83F17 for ; Tue, 29 Aug 2023 08:31:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234162AbjH2Ia3 (ORCPT ); Tue, 29 Aug 2023 04:30:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234146AbjH2IaR (ORCPT ); Tue, 29 Aug 2023 04:30:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E2AEA4; Tue, 29 Aug 2023 01:30:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F001663408; Tue, 29 Aug 2023 08:30:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CE6CC433C7; Tue, 29 Aug 2023 08:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693297812; bh=3esHotHL2UZQIGFXwPHNiHq2AYICfZNGQboed3/La+0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ebk4Oqp3T/3PwRIzhPLKQSPhbKdSmH5wEldN4Qi/Yqt8XKD6E1dpOXbbgronnv2Dc oPzjB+8CYi3cb7/R4VuDR/DCDvE4iV0CqX1RB3bsTaX2zRDMtGASiFIRQs0WiSds87 0TWH+4G/0GaztGnYgj3fMasJ6FLoqsUFAranwIQGMcEskJrnJcOWyxUZ19Q0qZ82xp ekItrONmLmyyJL1O1mT7mFfKL/eNBdUEkQ2qWmkurAFGlzAfhB/B+LeSmf6I7Nc5SU 0IpD0YMnAHSTFuztcFJVsyZZ85QhBswtVt447baDJIZC06oaqIBeQQsRFLBu5gRFjt T8uKLhbjy4igw== From: Kalle Valo To: kernel test robot Cc: Ajay Singh , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: drivers/net/wireless/microchip/wilc1000/cfg80211.c:361:42: sparse: sparse: incorrect type in assignment (different base types) References: <202308290615.lUTIgqUl-lkp@intel.com> <877cpev0pn.fsf@kernel.org> Date: Tue, 29 Aug 2023 11:31:22 +0300 In-Reply-To: <877cpev0pn.fsf@kernel.org> (Kalle Valo's message of "Tue, 29 Aug 2023 09:09:40 +0300") Message-ID: <87a5uatfl1.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kalle Valo writes: > kernel test robot writes: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >> head: 727dbda16b83600379061c4ca8270ef3e2f51922 >> commit: c5b331d4f550fb78bf1a553b2517616a5ea913d6 wifi: wilc1000: add WPA3 SAE support >> date: 1 year, 3 months ago >> config: i386-randconfig-063-20230829 (https://download.01.org/0day-ci/archive/20230829/202308290615.lUTIgqUl-lkp@intel.com/config) >> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230829/202308290615.lUTIgqUl-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202308290615.lUTIgqUl-lkp@intel.com/ >> >> sparse warnings: (new ones prefixed by >>) >>>> drivers/net/wireless/microchip/wilc1000/cfg80211.c:361:42: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int key_mgmt_suite @@ got restricted __be32 [usertype] @@ >> drivers/net/wireless/microchip/wilc1000/cfg80211.c:361:42: sparse: expected unsigned int key_mgmt_suite >> drivers/net/wireless/microchip/wilc1000/cfg80211.c:361:42: sparse: got restricted __be32 [usertype] > > Yeah, this is an old issue but we really should try to fix this, > especially so as I would like to make wireless code sparse warning free > in the near future. IIRC there were some problems with nl80211 interface > as well so this might not be simple fix still. For reference here's the old discussion: https://patchwork.kernel.org/project/linux-wireless/patch/20220720160302.231516-1-ajay.kathat@microchip.com/ Any volunteers to help fix this? I would prefers fixes for issues like this compared to questionable random cleanups we always get. Maybe we should come up with a todo list somewhere and advocate the "cleaners" to work on those items instead? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches