From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A5DC0015E for ; Sat, 12 Aug 2023 08:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbjHLIRH (ORCPT ); Sat, 12 Aug 2023 04:17:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbjHLIRF (ORCPT ); Sat, 12 Aug 2023 04:17:05 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45DC2CE for ; Sat, 12 Aug 2023 01:17:04 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C034F2189C; Sat, 12 Aug 2023 08:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691828222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IvbMXIj3oMLFsiOocJzfiZGs8fX86KHXcj7ZvFKQQVk=; b=O7RGBn5moLPNITcUn0kfD/vOLcBD6GFK4QnVYDsjy7Qz8afPdJ22PHrKAYo5HP3Yw8Y4+v 84b8DzhjYKJja13IMOfaxTECXLiw9ltjQOwdHo8FdEK1UZ2cZOIfzQIlhAE9haZlBZQeMX qjG9acIyKUKKfRzLo+UVFGblrX+w7Yk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691828222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IvbMXIj3oMLFsiOocJzfiZGs8fX86KHXcj7ZvFKQQVk=; b=L9q1qNWagPfhKOtQ3dwiY6eHpudGDCwrbAGeYO6vSzT/GsVQv3x0tUbvjVy4hj93o1301Y t2vdxLf060vLxmAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 45A4613274; Sat, 12 Aug 2023 08:17:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eZH/Dv4/12S9FgAAMHmgww (envelope-from ); Sat, 12 Aug 2023 08:17:02 +0000 Date: Sat, 12 Aug 2023 10:17:01 +0200 Message-ID: <87a5uwr7ya.wl-tiwai@suse.de> From: Takashi Iwai To: Pierre-Louis Bossart Cc: Maarten Lankhorst , alsa-devel@alsa-project.org, Maarten Lankhorst , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Daniel Baluta , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v3 8/9] ASoC: SOF: Intel: Move binding to display driver outside of deferred probe In-Reply-To: <4acc7318-69b3-3eb5-1fe8-f7deea8adfad@linux.intel.com> References: <20230807090045.198993-1-maarten.lankhorst@linux.intel.com> <20230807090045.198993-9-maarten.lankhorst@linux.intel.com> <4acc7318-69b3-3eb5-1fe8-f7deea8adfad@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Aug 2023 16:26:53 +0200, Pierre-Louis Bossart wrote: > > > > On 8/7/23 04:00, Maarten Lankhorst wrote: > > Now that we can use -EPROBE_DEFER, it's no longer required to spin off > > the snd_hdac_i915_init into a workqueue. > > > > Use the -EPROBE_DEFER mechanism instead, which must be returned in the > > probe function. > > I don't think this patch is aligned with the previous discussions. What > we agreed on is that snd_hdac_i915_init() would be called from and not > from the workqueue. > > But this patch also moves all codec initialization out of the workqueue. > > I think we need two callbacks for device-specific initilization, one > that is called from the probe function and one from the workqueue, > otherwise we'll have a structure that differs from the snd-hda-intel - > which would be rather silly in terms of support/debug. > > I realize there's quite a bit of surgery involved, and most likely the > SOF folks should provide this patch for you to build on. So this patch looks like the only significant concern in the whole patch set. Can we reach to some agreement for merging to 6.6 in time? thanks, Takashi