From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BA61C7EE24 for ; Wed, 10 May 2023 08:06:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236537AbjEJIGY (ORCPT ); Wed, 10 May 2023 04:06:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231175AbjEJIGU (ORCPT ); Wed, 10 May 2023 04:06:20 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 711431FC7 for ; Wed, 10 May 2023 01:06:19 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0DB6D21ADC; Wed, 10 May 2023 08:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683705978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AIn9dMlGX57qADgU5sVGhgMAmniYi84QyI4AhbTr4fo=; b=IwQ7Q0EQNrhrqdcBDRee3SUA+hYmy3U2txJFNueaQuzeQ/4sRA2e9vmX/Ab5RSZucCkHFn jFox3PUjR8zsrX65Zhj/xV3bnESrrg+2wdngbIJNRCXyKLbm98+E2kFOQOYNqSkKq398L7 gxmj9bBEo5/j/wXPuCXe3LrTHC3mP5E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683705978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AIn9dMlGX57qADgU5sVGhgMAmniYi84QyI4AhbTr4fo=; b=GMKQzn4mT0Uj6ACH2YHTPFBRpwTBHx+Lmq0c5l50VooP8S5BLQgQvLmV0RAvSk0TjwHr66 uBsuoWRycUAEhSDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6744313519; Wed, 10 May 2023 08:06:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id K/pCGHlQW2SjXQAAMHmgww (envelope-from ); Wed, 10 May 2023 08:06:17 +0000 Date: Wed, 10 May 2023 10:06:16 +0200 Message-ID: <87a5yc626f.wl-tiwai@suse.de> From: Takashi Iwai To: Ivan Orlov Cc: perex@perex.cz, tiwai@suse.com, oswald.buddenhagen@gmx.de, axboe@kernel.dk, 42.hyeyoo@gmail.com, surenb@google.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm_native.c In-Reply-To: References: <20230510072726.435247-1-ivan.orlov0322@gmail.com> <2023051052-recoil-headache-1594@gregkh> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 May 2023 09:55:18 +0200, Ivan Orlov wrote: > > On 5/10/23 11:48, Greg KH wrote: > > - Your patch did many different things all at once, making it difficult > > to review. All Linux kernel patches need to only do one thing at a > > time. If you need to do multiple things (such as clean up all coding > > style issues in a file/driver), do it in a sequence of patches, each > > one doing only one thing. This will make it easier to review the > > patches to ensure that they are correct, and to help alleviate any > > merge issues that larger patches can cause. > > > > If you wish to discuss this problem further, or you have questions about > > how to resolve this issue, please feel free to respond to this email and > > Greg will reply once he has dug out from the pending patches received > > from other developers. > > > > thanks, > > > > greg k-h's patch email bot > > Greg's Bot is right, it will be better as a sequence of patches. Sorry > for bothering! Also, if it's only about white space fix or some indent level issues, that could be rather more noise and disturbs the git change history, e.g. it makes difficult to find out the real code changes via git blame, especially it touches a huge amount of lines like this. That said, I'm not going to take such "coding style cleanup" patch blindly. If it's associated with other real fix or enhancement, I'll happily take it. Otherwise, I'd rather leave it. thanks, Takashi