From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AF0EC77B7C for ; Fri, 5 May 2023 15:15:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232488AbjEEPPa (ORCPT ); Fri, 5 May 2023 11:15:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231987AbjEEPP1 (ORCPT ); Fri, 5 May 2023 11:15:27 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CD2417DDF for ; Fri, 5 May 2023 08:15:26 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 11CA22018F; Fri, 5 May 2023 15:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683299725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rQXhkEDxslMaIbs8zVFGpIVuXLaDUqlVqpZj4V0XniY=; b=zJdVhRywY2h9ZhQ8hrz2GnFtSYZyGUA4vPUjoAWkryA2fgPBjVeJUl9LpuM1RemHntOOSW 8e/BSOseLunrMk/s0UUblStSou/J5Ibez5C6+pr9ZE5OAbF2O2LeR4XpP62C7y+vh+1ISz TKIUlaEzQSb3cmFb3qVxKj0EwptNi6c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683299725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rQXhkEDxslMaIbs8zVFGpIVuXLaDUqlVqpZj4V0XniY=; b=b5HPUwtfIzbM5aQ4g2aaexXuyZCMd0BvDDsUZBYnIb3AT7VI1tlQUQYV+MMsIRWR+DVOda XWdhKioBMvoZ32Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DC52A13513; Fri, 5 May 2023 15:15:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id n1ogNIwdVWTKCgAAMHmgww (envelope-from ); Fri, 05 May 2023 15:15:24 +0000 Date: Fri, 05 May 2023 17:15:24 +0200 Message-ID: <87a5yiizcj.wl-tiwai@suse.de> From: Takashi Iwai To: Luke Jones Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.com Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for 2nd ASUS GU603 In-Reply-To: References: <20230503035035.254346-1-luke@ljones.dev> <87h6sune0i.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 04 May 2023 02:41:09 +0200, Luke Jones wrote: > > On Wed, May 3 2023 at 08:08:13 +0200, Takashi Iwai > wrote: > > On Wed, 03 May 2023 05:50:35 +0200, > > Luke D. Jones wrote: > >> > >> Add quirk for GU603 with 0x1c62 variant of codec. > >> > >> Signed-off-by: Luke D. Jones > >> --- > >> sound/pci/hda/patch_realtek.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/sound/pci/hda/patch_realtek.c > >> b/sound/pci/hda/patch_realtek.c > >> index 3b9f077a227f..4a585050edc3 100644 > >> --- a/sound/pci/hda/patch_realtek.c > >> +++ b/sound/pci/hda/patch_realtek.c > >> @@ -9501,6 +9501,7 @@ static const struct snd_pci_quirk > >> alc269_fixup_tbl[] = { > >> SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", > >> ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > >> SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", > >> ALC294_FIXUP_ASUS_DUAL_SPK), > >> SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", > >> ALC289_FIXUP_ASUS_GA401), > >> + SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", > >> ALC289_FIXUP_ASUS_GA401), > >> SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", > >> ALC269_FIXUP_STEREO_DMIC), > >> SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", > >> ALC295_FIXUP_ASUS_DACS), > >> SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", > >> ALC294_FIXUP_ASUS_DUAL_SPK), > > > > Could you try to put the new entry at the right place? > > The table is sorted in the PCI SSID order. > > > > > > thanks, > > > > Takashi > > Sure no problem. Sorry, seems I read `0x1c62` and `0x16c2` :( So, which number is correct? Isn't it 0x16c2? This sounds more reasonable. In anyway, please resubmit a proper patch after confirming that it's really working. thanks, Takashi