public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Egorenkov <egorenar@linux.ibm.com>
To: dhowells@redhat.com
Cc: axboe@kernel.dk, david@redhat.com, hch@infradead.org, hch@lst.de,
	hdanton@sina.com, jack@suse.cz, jgg@nvidia.com,
	jhubbard@nvidia.com, jlayton@kernel.org,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	logang@deltatee.com, viro@zeniv.linux.org.uk,
	willy@infradead.org
Cc: Marc Hartmayer <mhartmay@linux.ibm.com>
Subject: Re: [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE
Date: Fri, 17 Feb 2023 21:39:07 +0100	[thread overview]
Message-ID: <87a61ckowk.fsf@oc8242746057.ibm.com> (raw)
In-Reply-To: <20230214171330.2722188-9-dhowells@redhat.com>
In-Reply-To: 

Hello,

this commit breaks our s390x tests on linux-next which use Python 3
among other things.

We are using the Python 3 tox module and for some reason,
the above commit makes Python create files with padded zeroes.

--- a/tox/distro/lib/python3.11/site-packages/_distutils_hack/__init__.py
+++ b/tox/distro/lib/python3.11/site-packages/_distutils_hack/__init__.py
@@ -381,133 +381,4 @@
 000017c0  49 4c 53 5f 46 49 4e 44  45 52 29 0a 20 20 20 20  |ILS_FINDER).    |
 000017d0  65 78 63 65 70 74 20 56  61 6c 75 65 45 72 72 6f  |except ValueErro|
 000017e0  72 3a 0a 20 20 20 20 20  20 20 20 70 61 73 73 0a  |r:.        pass.|
-000017f0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
-00001800  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
-00001810  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
-00001820  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
-00001830  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
-00001840  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
-00001850  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
-00001860  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
... 

How to reproduce on Fedora
--------------------------

# dnf install -y python3-tox

# cat >tox.ini <<EOF
[tox]
envlist = dev,distro,doc,lint
skipsdist = True

[testenv:distro]
sitepackages = true
EOF

# python3 -m tox -v --notest -e distro

Error processing line 1 of /mnt/test/.tox/distro/lib/python3.11/site-packages/distutils-precedence.pth:

  Traceback (most recent call last):
    File "<frozen site>", line 186, in addpackage
    File "<string>", line 1, in <module>
  ValueError: source code string cannot contain null bytes

Remainder of file ignored

# The above error message disappears if one reverts the bad commit.

Regards
Alex

  parent reply	other threads:[~2023-02-17 20:39 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 17:13 [PATCH v14 00/17] iov_iter: Improve page extraction (pin or just list) David Howells
2023-02-14 17:13 ` [PATCH v14 01/17] mm: Pass info, not iter, into filemap_get_pages() David Howells
2023-02-14 17:13 ` [PATCH v14 02/17] splice: Add a func to do a splice from a buffered file without ITER_PIPE David Howells
2023-02-18  2:41   ` Ming Lei
2023-02-18  9:25     ` David Howells
2023-02-14 17:13 ` [PATCH v14 03/17] splice: Add a func to do a splice from an O_DIRECT " David Howells
2023-02-14 17:13 ` [PATCH v14 04/17] shmem: Implement splice-read David Howells
2023-02-14 17:13 ` [PATCH v14 05/17] overlayfs: " David Howells
2023-02-15 14:21   ` Miklos Szeredi
2023-02-15 15:03     ` David Howells
2023-02-15 15:32       ` Miklos Szeredi
2023-02-15 15:40     ` [PATCH v15 " David Howells
2023-02-15 15:50       ` Miklos Szeredi
2023-02-15 15:53         ` Matthew Wilcox
2023-02-15 16:38           ` Christoph Hellwig
2023-02-15 16:40           ` Miklos Szeredi
2023-02-15 15:58         ` David Howells
2023-02-14 17:13 ` [PATCH v14 06/17] coda: " David Howells
2023-02-14 18:04   ` Jan Harkes
2023-02-14 17:13 ` [PATCH v14 07/17] tty, proc, kernfs, random: Use direct_splice_read() David Howells
2023-02-14 17:13 ` [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE David Howells
2023-02-17  8:22   ` Ming Lei
2023-02-17  9:18     ` Ming Lei
2023-02-17 20:39   ` Alexander Egorenkov [this message]
2023-02-17 20:59     ` egorenar
2023-02-17 21:24       ` David Howells
2023-02-17 21:16     ` David Howells
2023-02-17 21:47     ` David Howells
2023-02-18  8:29       ` Alexander Egorenkov
2023-02-18  9:18         ` David Howells
2023-02-14 17:13 ` [PATCH v14 09/17] iov_iter: Kill ITER_PIPE David Howells
2023-02-14 17:13 ` [PATCH v14 10/17] iov_iter: Define flags to qualify page extraction David Howells
2023-02-14 17:13 ` [PATCH v14 11/17] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-02-14 17:13 ` [PATCH v14 12/17] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-02-14 17:13 ` [PATCH v14 13/17] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-02-14 17:13 ` [PATCH v14 14/17] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic David Howells
2023-02-14 17:13 ` [PATCH v14 15/17] block: Add BIO_PAGE_PINNED and associated infrastructure David Howells
2023-02-14 17:13 ` [PATCH v14 16/17] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-02-14 17:13 ` [PATCH v14 17/17] block: convert bio_map_user_iov " David Howells
2023-02-14 22:56 ` [PATCH v14 00/17] iov_iter: Improve page extraction (pin or just list) David Howells
2023-02-14 23:01   ` David Howells
2023-02-14 23:05   ` Jens Axboe
2023-02-15  8:07     ` David Howells
2023-02-15  8:20       ` David Howells
2023-02-15 14:23       ` Christoph Hellwig
2023-02-15 14:38         ` Christoph Hellwig
2023-02-15 15:43           ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a61ckowk.fsf@oc8242746057.ibm.com \
    --to=egorenar@linux.ibm.com \
    --cc=axboe@kernel.dk \
    --cc=david@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=hdanton@sina.com \
    --cc=jack@suse.cz \
    --cc=jgg@nvidia.com \
    --cc=jhubbard@nvidia.com \
    --cc=jlayton@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=logang@deltatee.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox