From: Michael Ellerman <mpe@ellerman.id.au>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>, "Pali Rohár" <pali@kernel.org>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
Date: Thu, 01 Dec 2022 21:40:03 +1100 [thread overview]
Message-ID: <87a647s8zg.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20221130141040.32447-6-arinc.unal@arinc9.com>
Arınç ÜNAL <arinc.unal@arinc9.com> writes:
> This is not used by the DSA dt-binding, so remove it from all devicetrees.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> arch/powerpc/boot/dts/turris1x.dts | 2 --
> 1 file changed, 2 deletions(-)
Adding Pali to Cc.
These were only recently updated in commit:
8bf056f57f1d ("powerpc: dts: turris1x.dts: Fix labels in DSA cpu port nodes")
Which said:
DSA cpu port node has to be marked with "cpu" label.
But if the binding doesn't use them then I'm confused why they needed to
be updated.
cheers
> diff --git a/arch/powerpc/boot/dts/turris1x.dts b/arch/powerpc/boot/dts/turris1x.dts
> index 045af668e928..3841c8d96d00 100644
> --- a/arch/powerpc/boot/dts/turris1x.dts
> +++ b/arch/powerpc/boot/dts/turris1x.dts
> @@ -147,7 +147,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - label = "cpu";
> ethernet = <&enet1>;
> phy-mode = "rgmii-id";
>
> @@ -184,7 +183,6 @@ port@5 {
>
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&enet0>;
> phy-mode = "rgmii-id";
>
> --
> 2.34.1
next prev parent reply other threads:[~2022-12-01 10:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 14:10 [PATCH 0/5] remove label = "cpu" from DSA dt-binding Arınç ÜNAL
2022-11-30 14:10 ` [PATCH 1/5] dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples Arınç ÜNAL
2022-12-01 6:13 ` Oleksij Rempel
2022-12-01 23:46 ` Rob Herring
2022-11-30 14:10 ` [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding Arınç ÜNAL
2022-11-30 14:51 ` Geert Uytterhoeven
2022-12-01 6:20 ` Oleksij Rempel
2022-12-04 21:31 ` Linus Walleij
2022-12-05 20:10 ` Jernej Škrabec
2022-11-30 14:10 ` [PATCH 3/5] arm64: " Arınç ÜNAL
2022-11-30 18:40 ` Heiko Stübner
2022-11-30 14:10 ` [PATCH 4/5] mips: " Arınç ÜNAL
2022-12-01 6:04 ` Sergio Paracuellos
2022-12-01 6:13 ` Oleksij Rempel
2022-12-01 10:53 ` Thomas Bogendoerfer
2022-11-30 14:10 ` [PATCH 5/5] powerpc: " Arınç ÜNAL
2022-12-01 10:40 ` Michael Ellerman [this message]
2022-12-01 17:39 ` Pali Rohár
2022-12-01 23:44 ` Rob Herring
2022-12-02 19:35 ` Pali Rohár
2022-12-04 18:59 ` Vladimir Oltean
2022-12-05 19:15 ` Arınç ÜNAL
2022-12-07 13:13 ` Vladimir Oltean
2022-11-30 15:55 ` [PATCH 0/5] " Andrew Lunn
2022-11-30 17:22 ` Arınç ÜNAL
2022-12-01 10:42 ` Michael Ellerman
2022-12-01 11:37 ` Arınç ÜNAL
2022-12-01 9:14 ` Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a647s8zg.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=arinc.unal@arinc9.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox