From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E40CECAAA3 for ; Fri, 26 Aug 2022 06:08:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244735AbiHZGI2 (ORCPT ); Fri, 26 Aug 2022 02:08:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229701AbiHZGIY (ORCPT ); Fri, 26 Aug 2022 02:08:24 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E0EBC4818 for ; Thu, 25 Aug 2022 23:08:24 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BB92D227C0; Fri, 26 Aug 2022 06:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1661494102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xCXozoclkHh9HB5LH7ku4LFTxjoXrdn4pmU+Orsqo04=; b=EKQR/LjFvRTS8mCIG1M0v8+YYMhDu4/W/mic2GCljX2ykPKCT494RauNCIX7AXkPterkqi +mfHJ5SWq1fS1kzXet32LmT+R9VC7StyBrBttSMdQymp361EY8rmI1CrNujCLN7UJiGtF5 MY/Fbt2/beGi+DNwh2NASjzYnozVcCQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1661494102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xCXozoclkHh9HB5LH7ku4LFTxjoXrdn4pmU+Orsqo04=; b=yvKx+Ki+2f68SPUkQNYuVrY59Ou7UY9UY+nGY2CfKLda93y57TPeXdgo9zEDBJYva2iH2V eZuv1Lz/C1kgEeBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 933F113A7E; Fri, 26 Aug 2022 06:08:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id S644I1ZjCGMvbgAAMHmgww (envelope-from ); Fri, 26 Aug 2022 06:08:22 +0000 Date: Fri, 26 Aug 2022 08:08:21 +0200 Message-ID: <87a67rlep6.wl-tiwai@suse.de> From: Takashi Iwai To: "Luke D. Jones" Cc: tiwai@suse.com, kai.heng.feng@canonical.com, andy.chi@canonical.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] sound: realtek: Add pincfg for ASUS G533Z In-Reply-To: <20220825220130.331371-1-luke@ljones.dev> References: <20220825220130.331371-1-luke@ljones.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Aug 2022 00:01:29 +0200, Luke D. Jones wrote: > > Fixes up the pincfg for ASUS ROG Strix G15 (G533Z) laptop. > > Signed-off-by: Luke D. Jones Just minor nitpicking: > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5828,7 +5828,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec, > struct alc_spec *spec = codec->spec; > spec->parse_flags |= HDA_PINCFG_HEADSET_MIC; > alc255_set_default_jack_type(codec); > - } > + } > else > alc_fixup_headset_mode(codec, fix, action); > } Please avoid touching unnecessary parts. > @@ -8363,6 +8364,17 @@ static const struct hda_fixup alc269_fixups[] = { > .type = HDA_FIXUP_FUNC, > .v.func = alc294_fixup_gu502_hp, > }, > + [ALC285_FIXUP_ASUS_G533Z_PINS] = { > + .type = HDA_FIXUP_PINS, > + .v.pins = (const struct hda_pintbl[]) { > + { 0x14, 0x90170120 }, > + { 0x19, 0x03A11050 }, /* front HP mic */ > + { 0x1B, 0x03A11C30 }, /* rear external mic */ > + { 0x21, 0x03211420 }, /* front HP out */ We prefer the lower letters for hex numbers. > + { } > + }, > + .chained = false, This is initialization superfluous, please drop. Last but not least, the subject prefix should be rather "ALSA:" instead of "sound:". The same applied to the second patch. Could you try to address those and resubmit as v2? thanks, Takashi