From: Thomas Gleixner <tglx@linutronix.de>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, linux-kernel@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
stable@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v4 RESEND] timekeeping: contribute wall clock to rng on time change
Date: Mon, 18 Jul 2022 14:20:37 +0200 [thread overview]
Message-ID: <87a696wr1m.ffs@tglx> (raw)
In-Reply-To: <20220717215334.221236-1-Jason@zx2c4.com>
On Sun, Jul 17 2022 at 23:53, Jason A. Donenfeld wrote:
> The rng's random_init() function contributes the real time to the rng at
> boot time, so that events can at least start in relation to something
> particular in the real world. But this clock might not yet be set that
> point in boot, so nothing is contributed. In addition, the relation
> between minor clock changes from, say, NTP, and the cycle counter is
> potentially useful entropic data.
>
> This commit addresses this by mixing in a time stamp on calls to
> settimeofday and adjtimex. No entropy is credited in doing so, so it
> doesn't make initialization faster, but it is still useful input to
> have.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@vger.kernel.org
> Reviewed-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2022-07-18 12:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 16:52 [PATCH] timekeeping: contribute wall clock to rng on time change Jason A. Donenfeld
2022-06-23 17:39 ` Eric Biggers
2022-06-23 18:04 ` Jason A. Donenfeld
2022-06-23 18:05 ` [PATCH v2] " Jason A. Donenfeld
2022-06-23 18:53 ` Eric Biggers
2022-06-23 18:56 ` Jason A. Donenfeld
2022-06-23 19:00 ` [PATCH v3] " Jason A. Donenfeld
2022-06-23 19:10 ` Eric Biggers
2022-06-23 19:11 ` Jason A. Donenfeld
2022-06-23 19:12 ` [PATCH v4] " Jason A. Donenfeld
2022-06-23 19:36 ` Eric Biggers
2022-06-30 13:06 ` Jason A. Donenfeld
2022-07-17 21:53 ` [PATCH v4 RESEND] " Jason A. Donenfeld
2022-07-18 12:20 ` Thomas Gleixner [this message]
2022-06-23 18:04 ` [PATCH] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a696wr1m.ffs@tglx \
--to=tglx@linutronix.de \
--cc=Jason@zx2c4.com \
--cc=ebiggers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox